<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125018/">https://git.reviewboard.kde.org/r/125018/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 7th, 2015, 4:48 p.m. CEST, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/125018/diff/1/?file=399916#file399916line234" style="color: black; font-weight: bold; text-decoration: underline;">src/client/dpms.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">234</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="nf">modeChanged</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Perhaps carry the new mode in this signal?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No, I decided against that when implementing it (I thought about it). Somehow I feel carrying the arg around makes it needlessly more difficult (you need to declare metatype, call qRegisterMetaType) for not much gain: it's just one const call away anyway.</p></pre>
<br />
<p>- Martin</p>
<br />
<p>On September 1st, 2015, 2:05 p.m. CEST, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, Kai Uwe Broulik and Sebastian Kügler.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Sept. 1, 2015, 2:05 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwayland
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Allows to retrieve the OutputInterface* for a given native wl_resource.
To support this we need to track the resources bound for each Output.
[server] Add a DpmsManagerInterface
Adding support for a org_kde_kwin_dpms interface. On server side
Dpms is mostly bound to the OutputInterface exposing just a very
small manager. Whether Dpms is supported and which mode is used is
tracked directly on the OutputInterface.
[client] Dpms protocol
[tests] Add an example for the Dpms interface
Uses QWidgets to render a very small UI.
* lists each Output
* for each output shows whether dpms is supported
* and which dpms mode it's in
* and provides a button to change the mode
[autotests] Extend tests for Dpms</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See added test application.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/client/test_wayland_output.cpp <span style="color: grey">(cb2892a18c58eb1ebb2482fc76243876b7ea26a7)</span></li>
<li>autotests/client/test_wayland_registry.cpp <span style="color: grey">(a38066aeccec43edff26b10ebe89d31ede0f9a99)</span></li>
<li>src/client/CMakeLists.txt <span style="color: grey">(7d0d38ab20be9d4c9becd64fb12d81480f6a8cf6)</span></li>
<li>src/client/dpms.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/client/dpms.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/client/protocols/dpms.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/client/registry.h <span style="color: grey">(c5956956db542737c9cd22c0823c1bc092dbfbef)</span></li>
<li>src/client/registry.cpp <span style="color: grey">(c7092642b308e6e49f4fd9515e87ffc1c8ea13a8)</span></li>
<li>src/server/CMakeLists.txt <span style="color: grey">(1cf09d3ab636497c59d34a5c1acb8e95a4d2ea17)</span></li>
<li>src/server/display.h <span style="color: grey">(4c0e0c71ef7c6bec8e24003a86e9ee12729babf9)</span></li>
<li>src/server/display.cpp <span style="color: grey">(884d7ea2feb2a67a1eace58e279b5722186e6c17)</span></li>
<li>src/server/dpms_interface.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/server/dpms_interface.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/server/dpms_interface_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/server/output_interface.h <span style="color: grey">(080ec7f7867795628f6ac243849d4ddd0c67e11a)</span></li>
<li>src/server/output_interface.cpp <span style="color: grey">(ccf305d19a0b57cb5082d5e644c6bd83c0bfdd8d)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(44712ece1a6a2d9566594fee910c711742c6ab01)</span></li>
<li>tests/dpmstest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125018/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>