<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125058/">https://git.reviewboard.kde.org/r/125058/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Septembrie 6th, 2015, 5:22 a.m. EEST, <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Have you thought of the corner cases?
These come to my mind:
- Is it possible to add the same folder to both lists? If so: Which one wins?
- It ist possible to add a folder to index within an excluded folder? If so: what happens?
- Is it possible to exclude a folder which is <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">not</em> within an included folder (not strictly a problem as it would simply have no effect, but strange nonetheless)?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You are right. I didn't consider those scenarios.
1. In this case, the decision is up to baloo, but I'll look into implementing a failsafe to not alow this.
2. Again, the question is: if baloo accepts this. I don't see why this shouldn't be allowed. Currently there is nothing in the KCM stoping this to happen.
3. Yes, it is. Maybe someone is really paranoia, and they whant to make sure that that directory does not get indexexd under any circumstances.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Another scenario would be if a directory is added to be excluded, but there are currently child directories of that directory that are included. In this case, I'd show a warning, but let the user do it.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">P.S. Please take a look over the Review Requests that this one depends on. I can't submit the other patches untill these are in the repo. They depend on these.</p></pre>
<br />
<p>- Ovidiu-Florin</p>
<br />
<p>On Septembrie 5th, 2015, 11:11 p.m. EEST, Ovidiu-Florin BOGDAN wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Baloo, Plasma, KDE Usability, Pinak Ahuja, and Vishesh Handa.</div>
<div>By Ovidiu-Florin BOGDAN.</div>
<p style="color: grey;"><i>Updated Sept. 5, 2015, 11:11 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Added the functionality to add directories to be indexed.
Did some cleaning up.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Screenshot of the new look: http://i.imgur.com/RBWxutv.png</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested add, remove include and exclude directories.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcms/baloo/CMakeLists.txt <span style="color: grey">(7415289)</span></li>
<li>kcms/baloo/configwidget.ui <span style="color: grey">(512e4a5)</span></li>
<li>kcms/baloo/folderselectionwidget.h <span style="color: grey">(226ab45)</span></li>
<li>kcms/baloo/folderselectionwidget.cpp <span style="color: grey">(b44d111)</span></li>
<li>kcms/baloo/kcm.h <span style="color: grey">(6ff5813)</span></li>
<li>kcms/baloo/kcm.cpp <span style="color: grey">(27d93e2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125058/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>