<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125030/">https://git.reviewboard.kde.org/r/125030/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 3rd, 2015, 11:12 a.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/125030/diff/1/?file=400105#file400105line172" style="color: black; font-weight: bold; text-decoration: underline;">autotests/client/test_wayland_contrast.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">172</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">serverSurface</span><span class="o">-></span><span class="n">contrast</span><span class="p">()</span><span class="o">-></span><span class="n">contrast</span><span class="p">(),</span> <span class="mf">0.2</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">what do we do about the failing test?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">no idea, this fixed datatype seems tricky.. what do you suggest?</p></pre>
<br />
<p>- Marco</p>
<br />
<p>On September 2nd, 2015, 4:23 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Sept. 2, 2015, 4:23 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwayland
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">new wayland protocol used to define regions behind a window
in which the kwin background contrast effect should be applied</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">fail in autotests: fun converting between double and "fixed"
Actual (serverSurface->contrast()->contrast()): 0.199219
Expected (0.2) : 0.2</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/client/CMakeLists.txt <span style="color: grey">(acc1cc0)</span></li>
<li>autotests/client/test_wayland_contrast.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/client/CMakeLists.txt <span style="color: grey">(e269997)</span></li>
<li>src/client/contrast.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/client/contrast.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/client/protocols/contrast.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/client/registry.h <span style="color: grey">(2a31ab4)</span></li>
<li>src/client/registry.cpp <span style="color: grey">(e890c69)</span></li>
<li>src/server/CMakeLists.txt <span style="color: grey">(9d99325)</span></li>
<li>src/server/display.h <span style="color: grey">(cd43b03)</span></li>
<li>src/server/display.cpp <span style="color: grey">(75adc14)</span></li>
<li>src/server/surface_interface.h <span style="color: grey">(f8f9be7)</span></li>
<li>src/server/surface_interface.cpp <span style="color: grey">(0f62d13)</span></li>
<li>src/server/surface_interface_p.h <span style="color: grey">(2b55f81)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125030/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>