<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125030/">https://git.reviewboard.kde.org/r/125030/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 2nd, 2015, 4:30 nachm. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'll re-raise general concerns about the contrast effect.
Why does it exist in the first place?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">https://bugs.kde.org/show_bug.cgi?id=337355#c12</p></pre>
</blockquote>
<p>On September 3rd, 2015, 9:06 vorm. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">purely for the looks. it does look very different than a more opaque panel, even if the readability is the same.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I would like to understand what the effect <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">wants</em> to do, for what it <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">seems</em> to do (afaics sligtly modified self-multiplication) does not require this wonky overhead (more plasma theme variants, more shader rebinding, ipc)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Details in https://bugs.kde.org/show_bug.cgi?id=337355#c8</p></pre>
<br />
<p>- Thomas</p>
<br />
<p>On September 3rd, 2015, 1:13 nachm. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Sept. 3, 2015, 1:13 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwayland
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">new wayland protocol used to define regions behind a window
in which the kwin background contrast effect should be applied</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">fail in autotests: fun converting between double and "fixed"
Actual (serverSurface->contrast()->contrast()): 0.199219
Expected (0.2) : 0.2</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/client/CMakeLists.txt <span style="color: grey">(acc1cc0)</span></li>
<li>autotests/client/test_wayland_contrast.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/client/CMakeLists.txt <span style="color: grey">(e269997)</span></li>
<li>src/client/contrast.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/client/contrast.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/client/protocols/contrast.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/client/registry.h <span style="color: grey">(2a31ab4)</span></li>
<li>src/client/registry.cpp <span style="color: grey">(e890c69)</span></li>
<li>src/server/CMakeLists.txt <span style="color: grey">(9d99325)</span></li>
<li>src/server/display.h <span style="color: grey">(cd43b03)</span></li>
<li>src/server/display.cpp <span style="color: grey">(75adc14)</span></li>
<li>src/server/surface_interface.h <span style="color: grey">(f8f9be7)</span></li>
<li>src/server/surface_interface.cpp <span style="color: grey">(0f62d13)</span></li>
<li>src/server/surface_interface_p.h <span style="color: grey">(2b55f81)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125030/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>