<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125026/">https://git.reviewboard.kde.org/r/125026/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 2nd, 2015, 12:07 p.m. CEST, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/125026/diff/1/?file=400055#file400055line27" style="color: black; font-weight: bold; text-decoration: underline;">daemon/actions/dpms/abstractdpmshelper.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">27</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">virtual</span> <span class="o">~</span><span class="n">AbstractDpmsHelper</span><span class="p">();</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">why = default not here?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">default in the header is problematic. E.g. if you use a QScopedPointer inside the class you can no longer forward declare it. Thus I never add the = default in the header and that's also the reason why I moved one.</p></pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 2nd, 2015, 12:07 p.m. CEST, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/125026/diff/1/?file=400057#file400057line48" style="color: black; font-weight: bold; text-decoration: underline;">daemon/actions/dpms/powerdevildpmsaction.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">45</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">,</span> <span class="n">m_fadeEffect</span><span class="p">(</span><span class="k">new</span> <span class="n">PowerDevil</span><span class="o">::</span><span class="n">KWinKScreenHelperEffect</span><span class="p">())</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">45</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">,</span> <span class="n">m_helper</span><span class="p">()</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why this?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">sorry, I don't get your question?</p></pre>
<br />
<p>- Martin</p>
<br />
<p>On September 2nd, 2015, 9:12 a.m. CEST, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, Solid and Kai Uwe Broulik.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Sept. 2, 2015, 9:12 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
powerdevil
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">An AbstractDpmsHelper is introduced with a concrete subclass called
XcbDpmsHelper. The PowerDevilDpmsAction holds a helper and delegates
to it. The XcbDpmsHelper implements the X11 specific tasks. This will
allow to add a Wayland implementation as well.
[dpms] Add a Wayland implementation
The Wayland implementation uses the DpmsManager provided by KWayland.
On a timeout it turns the screens off and it supports the trigger
modes. The fade helper is not supported (yet) as it is an X11 only
implementation.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">How I tested:
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> run kwin_wayland on a DRM device
</em> started kded5
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> configured powerdevil to suspend after one minute
</em> waited
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> watched screen go off
</em> enabled again, looked at debug output to verify it was triggered by powerdevil.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's currently only tested with Qt 5.4. At least for idle integration I had the problem that things somehow stopped working with 5.5. So this needs additional testing.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(457f74a318588690c3b9890a5bfdb0a4ea887042)</span></li>
<li>daemon/actions/dpms/CMakeLists.txt <span style="color: grey">(61d7b5684f85c29081dc863abbffa42898089d2a)</span></li>
<li>daemon/actions/dpms/abstractdpmshelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>daemon/actions/dpms/abstractdpmshelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>daemon/actions/dpms/powerdevildpmsaction.cpp <span style="color: grey">(ac824787d5907e78ce0f3ede0e822ffbc778cb3c)</span></li>
<li>daemon/actions/dpms/powerdevildpmsaction.desktop <span style="color: grey">(85ec8619bab9da70fddee4d8815ebdb8899000cd)</span></li>
<li>daemon/actions/dpms/powerdevildpmsaction.h <span style="color: grey">(d8b92784abc3717487050928c04c6022480cbd49)</span></li>
<li>daemon/actions/dpms/waylanddpmshelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>daemon/actions/dpms/waylanddpmshelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>daemon/actions/dpms/xcbdpmshelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>daemon/actions/dpms/xcbdpmshelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125026/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>