<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120563/">https://git.reviewboard.kde.org/r/120563/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 31st, 2015, 1:41 p.m. EEST, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is this still needed ? Comic works in Plasma 5 now.</p></pre>
<br />
<p>- Andrei</p>
<br />
<p>On Octombrie 12th, 2014, 7:05 p.m. EEST, Andrei Amuraritei wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, Bhushan Shah, David Edmundson, Marco Martin, and Martin Klapetek.</div>
<div>By Andrei Amuraritei.</div>
<p style="color: grey;"><i>Updated Oct. 12, 2014, 7:05 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This adds support for installing .comic type packages with plasmapkg2. This comes to help the comic dataengine port to frameworks, and permits the user to install .comic packages.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Apply patch, rebuild plasma-framework, compile ok. Then install a .comic package from kde-files.org Plasma/Comics with plasmapkg2 -t comic -i ~/Downloads/garfield.comic. </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Expected results:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Install method:
plasmapkg2 -t comic -i ~/Downloads/92037-garfield.comic</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">pluginname: "garfield"
-- Copying "/home/developer/.kde5-local/plasma/comics/garfield/metadata.desktop" "/home/developer/.kde5-local/kservices5/plasma-comic-garfield.desktop"
Copying metadata went ok.
Successfully installed /home/developer/Downloads/92037-garfield.comic</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Remove method:
plasmapkg2 -t comic -r ~/Downloads/92037-garfield.comic</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Trying to open ksycoca from "/home/developer/.kde5-cache/ksycoca5"
Successfully uninstalled /home/developer/Downloads/92037-garfield.comic</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Upgrade method:
plasmapkg2 -t comic -u ~/Downloads/92037-garfield.comic</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Trying to open ksycoca from "/home/developer/.kde5-cache/ksycoca5"
Upgrading package from file: /home/developer/Downloads/92037-garfield.comic
pluginname: "garfield"
-- Copying "/home/developer/.kde5-local/plasma/comics/garfield/metadata.desktop" "/home/developer/.kde5-local/kservices5/plasma-comic-garfield.desktop"
Copying metadata went ok.
Successfully upgraded /home/developer/Downloads/92037-garfield.comic</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasmapkg/plasmapkg.cpp <span style="color: grey">(7d55d0f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120563/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>