<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124915/">https://git.reviewboard.kde.org/r/124915/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and David Edmundson.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Aug. 25, 2015, 11:16 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=351696">351696</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If the greeter crashes on startup ksld is caught in a restart loop which
causes 100 % CPU usage and makes it impossible to unlock the session.
With this change the greeter is only allowed to crash four times and
ksld goes into an emergency mode. This mode ensures that our black
background window gets shown with a message indicating how to unlock
using loginctl. This is rather technical but better than leaving the
system in a state which makes it impossible to unlock.
Directly unlocking in the error case is not an option as that could
be used to attack the screen locker infrastructure.
BUG: 351696</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/screenlocker/autotests/CMakeLists.txt <span style="color: grey">(44bbd97add6f5c9b2f83f9f2f825fa3c904e45c5)</span></li>
<li>ksmserver/screenlocker/ksldapp.h <span style="color: grey">(03ca2580ffc564cde033f3eeb2c81f77179a0bde)</span></li>
<li>ksmserver/screenlocker/ksldapp.cpp <span style="color: grey">(d0636b8785101cb9896cea6399952dac0e4cd227)</span></li>
<li>ksmserver/screenlocker/lockwindow.h <span style="color: grey">(265699a9789703ad099eee043a14d4700e90c243)</span></li>
<li>ksmserver/screenlocker/lockwindow.cpp <span style="color: grey">(41af0e23f8442d75b7295debe50d9b29fbda7e7a)</span></li>
<li>ksmserver/screenlocker/tests/CMakeLists.txt <span style="color: grey">(613ec7b2eead38b36e7805804f25ed93b4ef7a68)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124915/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments (updated)</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/d90fa1f2-4400-4407-92f6-7d3dff49b3ed__screenlocker-emergency.png">Emergency mode</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>