<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124786/">https://git.reviewboard.kde.org/r/124786/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">the middle thing was done in order to not cross the handles, but the other check you afded should prevent this anyways</p></pre>
<br />
<p>- Marco Martin</p>
<br />
<p>On August 17th, 2015, 10:50 a.m. UTC, David Kahles wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Kahles.</div>
<p style="color: grey;"><i>Updated Aug. 17, 2015, 10:50 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Prevent users from moving the panel off the monitor, and prevent users
from moving a panel with center alignment to the left (right) and then
pull one of the right (left) sliders to the right (left). Because the
left and right sliders are coupled, this would make the left (right)
sliders to go off the monitor.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also fix that the left (right) sliders cannot be moved over the middle.
(In fact they can by using the offset slider, but as soon as on of the
left (right) handles are dragged, it sets the position back to the
middle).
I really don't know the reason for this behavior, and everything
works fine (or even better) without it. Does someone know whether this is needed and why?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also delete the default values for min/maxPosition in the SliderHandle,
as every handle sets its own min/maxPositions now.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">And should I add such checks also to panelview.cpp to prevent loading an invalid panel position/size from the config?
(Though this should only happen when a user changes the config manually) There are some checks, but not everything is checked..</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I know no way to set an invalid position/size as I could before. It works for horizontal and vertical panels.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>desktoppackage/contents/configuration/panelconfiguration/Ruler.qml <span style="color: grey">(a31feb40598ba24a107f41ff3b3f823afaa89da6)</span></li>
<li>desktoppackage/contents/configuration/panelconfiguration/SliderHandle.qml <span style="color: grey">(3480ce65a961d498055b3952d2d57b4f5d881a9a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124786/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>