<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124885/">https://git.reviewboard.kde.org/r/124885/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On agost 23rd, 2015, 1:47 a.m. UTC, <b>Jeremy Whiting</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
</blockquote>
<p>On agost 23rd, 2015, 1:47 a.m. UTC, <b>Jeremy Whiting</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Incidentally, the pt issue sounds like a QLocale bug, do we need to find one or file a new one for that probably?</p></pre>
</blockquote>
<p>On agost 23rd, 2015, 7:58 a.m. UTC, <b>John Layt</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yeah, looks a Qt bug, it has a table from CLDR of default countries to use so there's something wrong with the lookup. I'm not aware of a bug report for that so go ahead.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That, or Thiago has rigged it so he always gets pt_BR :-)</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's a "feature", gives you the countries in order of speakers, in this case portugal being the country with less portuguese speakers gets returned last after Brazil, Angola, etc. I do think it's a misfeature and weird since for "es" gives you Spain instead of Mexico or USA where there's more Spanish speakers. I'm going to try to open a bug upstream claiming that giving "pt" gives back "portugues do brazil" instead of "portugues" as https://www.loc.gov/standards/iso639-2/php/code_list.php says but not sure it's going to be easy so i'll commit this anyway.</p></pre>
<br />
<p>- Albert</p>
<br />
<p>On agost 23rd, 2015, 12:34 a.m. UTC, Albert Astals Cid wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Albert Astals Cid.</div>
<p style="color: grey;"><i>Updated ago. 23, 2015, 12:34 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=345761">345761</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=347956">347956</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixes two problems:
* Variants not being shown up, i.e. ca ca@valencia showing up both as "català"
* pt showing up as "português do Brasil"
For the first one i've went the easy route of adding the languageCode if there's an @ in it
For pt i hard to hard code it since i found no other way to make Qt understand that for "pt" we mean portuguese from portugal</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcms/translations/kcmtranslations.cpp <span style="color: grey">(e5024e2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124885/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>