<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124799/">https://git.reviewboard.kde.org/r/124799/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't think copying all of this is a good idea. Can this be shared somehow?</p></pre>
<br />
<p>- Kai Uwe Broulik</p>
<br />
<p>On August 18th, 2015, 12:55 vorm. UTC, Jeremy Whiting wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, andreas kainz and Sebastian Kügler.</div>
<div>By Jeremy Whiting.</div>
<p style="color: grey;"><i>Updated Aug. 18, 2015, 12:55 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
breeze
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">2 problems:
1. Switching themes causes konversation, krunner, and other applications to crash when applying the theme somehow.
2. The screenshots and assets are all copied directly from plasma-workspace, so the tooltip and such are wrong.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Switching between breeze, breeze dark, and oxygen seem to work, though some artifacts are left in some applications and some others crash for some reason. The backtrace looks like this:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Application: Konversation (konversation), signal: Segmentation fault
Using host libthread_db library "/usr/lib/libthread_db.so.1".
[Current thread is 1 (Thread 0x7f76e0f69840 (LWP 3767))]</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thread 2 (Thread 0x7f76c894d700 (LWP 3769)):</p>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">0 0x00007f76d8dc318d in poll () from /usr/lib/libc.so.6</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">1 0x00007f76d485bc7c in ?? () from /usr/lib/libglib-2.0.so.0</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">2 0x00007f76d485bd8c in g_main_context_iteration () from /usr/lib/libglib-2.0.so.0</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">3 0x00007f76d9c0f25b in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">4 0x00007f76d9bb626a in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">5 0x00007f76d99d2af4 in QThread::exec() () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">6 0x00007f76d99d7a9e in ?? () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">7 0x00007f76d63204a4 in start_thread () from /usr/lib/libpthread.so.0</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">8 0x00007f76d8dcc12d in clone () from /usr/lib/libc.so.6</h1>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thread 1 (Thread 0x7f76e0f69840 (LWP 3767)):
[KCrash Handler]</p>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">6 0x00007f76dade2f72 in QApplication::setStyle(QStyle*) () from /usr/lib/libQt5Widgets.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">7 0x00007f76dade3f06 in QApplication::setStyle(QString const&) () from /usr/lib/libQt5Widgets.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">8 0x00007f76c9c34733 in KHintsSettings::slotNotifyChange (this=0x1eef110, type=2, arg=0) at /home/jeremy/devel/kde/src/frameworks/frameworkintegration/src/platformtheme/khintssettings.cpp:274</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">9 0x00007f76c9c47007 in KHintsSettings::qt_static_metacall (_o=0x1eef110, _c=QMetaObject::InvokeMetaMethod, _id=3, _a=0x7fff0c69d1d0) at /home/jeremy/devel/kde/build/frameworks/frameworkintegration/src/platformtheme/moc_khintssettings.cpp:85</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">10 0x00007f76c9c47100 in KHintsSettings::qt_metacall (this=0x1eef110, _c=QMetaObject::InvokeMetaMethod, _id=3, _a=0x7fff0c69d1d0) at /home/jeremy/devel/kde/build/frameworks/frameworkintegration/src/platformtheme/moc_khintssettings.cpp:117</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">11 0x00007f76da29c293 in ?? () from /usr/lib/libQt5DBus.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">12 0x00007f76d9be7eb1 in QObject::event(QEvent*) () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">13 0x00007f76dade100c in QApplicationPrivate::notify_helper(QObject<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">, QEvent</em>) () from /usr/lib/libQt5Widgets.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">14 0x00007f76dade64e6 in QApplication::notify(QObject<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">, QEvent</em>) () from /usr/lib/libQt5Widgets.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">15 0x00007f76d9bb889b in QCoreApplication::notifyInternal(QObject<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">, QEvent</em>) () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">16 0x00007f76d9bbac96 in QCoreApplicationPrivate::sendPostedEvents(QObject<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">, int, QThreadData</em>) () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">17 0x00007f76d9c0ee33 in ?? () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">18 0x00007f76d485b9fd in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">19 0x00007f76d485bce0 in ?? () from /usr/lib/libglib-2.0.so.0</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">20 0x00007f76d485bd8c in g_main_context_iteration () from /usr/lib/libglib-2.0.so.0</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">21 0x00007f76d9c0f23f in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">22 0x00007f76d9bb626a in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">23 0x00007f76d9bbe20c in QCoreApplication::exec() () from /usr/lib/libQt5Core.so.5</h1>
<h1 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: inherit;">24 0x00000000004cbb35 in main (argc=1, argv=<optimized out>) at /home/jeremy/devel/kde/src/extragear/network/konversation/src/main.cpp:160</h1></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(aaae1ab9e242d7d4f9e1fb91990eef139668de74)</span></li>
<li>lookandfeel.dark/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/components/BreezeBlock.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/components/BreezeHeading.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/components/BreezeLabel.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/components/InfoPane.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/components/KeyboardLayoutButton.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/components/LogoutOptions.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/components/LogoutScreen.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/components/UserDelegate.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/components/UserList.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/components/UserSelect.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/components/artwork/README.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/components/artwork/background.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/components/artwork/logout_primary.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/components/artwork/restart_primary.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/components/artwork/shutdown_primary.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/defaults <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/desktopswitcher/DesktopSwitcher.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/lockscreen/LockScreen.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/loginmanager/Main.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/loginmanager/README.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/loginmanager/breeze.jpg <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/loginmanager/dummydata/screenModel.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/loginmanager/dummydata/sddm.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/loginmanager/dummydata/sessionModel.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/loginmanager/dummydata/userModel.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/loginmanager/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/loginmanager/theme.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/logout/Logout.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/logout/dummydata/screenGeometry.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/osd/Osd.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/osd/OsdItem.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/previews/desktopswitcher.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/previews/lockscreen.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/previews/loginmanager.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/previews/preview.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/previews/runcommand.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/previews/splash.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/previews/userswitcher.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/previews/windowdecoration.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/previews/windowswitcher.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/runcommand/RunCommand.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/splash/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/splash/Splash.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/splash/images/kde.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/userswitcher/UserSwitcher.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/windowdecoration/WindowDecoration.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/contents/windowswitcher/WindowSwitcher.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel.dark/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124799/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>