<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124695/">https://git.reviewboard.kde.org/r/124695/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Two notes:
a) no idea how epoxy works, but it doesn't link any GL library itself here (it's an epoxy build time dependency, though)
b) fglrx doesn't support EGL - though rather irrelevant since EGL from MESA will just be installed (as qt5-base dependency already) and not used, afaics there actually is a way to build a GLX system only.</p></pre>
<br />
<p>- Thomas Lübking</p>
<br />
<p>On August 11th, 2015, 8:29 vorm. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Aug. 11, 2015, 8:29 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It doesn't make much sense any more as we get EGL linked and included
through epoxy anyway. Even more on Wayland it's just plain stupid to
have EGL disabled. So removing the option just simplifies our code base
without any disadvantages.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libkwineffects/kwinglutils.cpp <span style="color: grey">(66634d6795d43020e9f323af9c24d8bfae9bf4aa)</span></li>
<li>libkwineffects/kwinconfig.h.cmake <span style="color: grey">(3e34723aea5baf519c16f53afef3b21ab43efe7c)</span></li>
<li>dbusinterface.cpp <span style="color: grey">(01079a1b2a97c83e4624deafb288349ea3952c7f)</span></li>
<li>backends/x11/x11windowed_backend.cpp <span style="color: grey">(3ba9e5cd3932574daff2062a289dfd00745fa776)</span></li>
<li>backends/wayland/CMakeLists.txt <span style="color: grey">(a1670a34b1f6519f6fb37bc041516bf3aec508e1)</span></li>
<li>CMakeLists.txt <span style="color: grey">(4d2aeed4f5ee9d0765e1b902ac51859e0ae1150b)</span></li>
<li>libkwineffects/kwinglutils_funcs.h <span style="color: grey">(eea28c5ae4225939a3d7fe72167fea4bfe028298)</span></li>
<li>libkwineffects/kwinglutils_funcs.cpp <span style="color: grey">(4e763b7bb1c4e156b52639dd357c92c5f28e9937)</span></li>
<li>options.cpp <span style="color: grey">(39efd9de53024fb7f11d042b7877a4583350b651)</span></li>
<li>scene_opengl.cpp <span style="color: grey">(85c0b104785ee2f06b1698d8e8020e0615fdab88)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124695/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>