<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124633/">https://git.reviewboard.kde.org/r/124633/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks good to me, just two small things.</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124633/diff/1/?file=390488#file390488line827" style="color: black; font-weight: bold; text-decoration: underline;">autotests/kservicetest.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">827</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">QFile</span><span class="o">::</span><span class="n">exists</span><span class="p">(</span><span class="n">fakePart</span><span class="p">))</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">why would it not exist? isn't it created by initTestCase(), therefore guaranteed to exist?</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124633/diff/1/?file=390491#file390491line171" style="color: black; font-weight: bold; text-decoration: underline;">src/services/kservice.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KServicePrivate::init(const KDesktopFile *config, KService *q)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">171</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_lstFormFactors</span> <span class="o">+=</span> <span class="n">desktopGroup</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span class="s">"X-KDE-FormFactors"</span><span class="p">,</span> <span class="n">QStringList</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The += isn't necessary, could just be =</p></pre>
</div>
</div>
<br />
<p>- David Faure</p>
<br />
<p>On August 5th, 2015, 8:57 p.m. UTC, Sebastian Kügler wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, Plasma, Alex Richardson, and David Faure.</div>
<div>By Sebastian Kügler.</div>
<p style="color: grey;"><i>Updated Aug. 5, 2015, 8:57 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kservice
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Parse formfactor in KService and KPluginInfo</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add an accessor QStringList KPluginInfo::formFactors()</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This corresponds to the X-KDE-FormFactors value in the .desktop file,
and to the "FormFactors" value in the "KPlugin" block of the json
metadata.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We already have this in KPluginMetaData, this patch brings KPluginInfo
and KService in line with that. Previously, the keys would not be
recognized, and thus be missing from the KPluginMetaData if created
through a KPluginInfo or a KService. This patch fixes this inconsistent
behaviour.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also bump the sycoca version.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Added new tests, no problems.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">ksycocathreadtest currently fails, but this is unrelated (also in master without this patch).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/fakeplugin.desktop <span style="color: grey">(200f02346d99caa585c39fc47ddb1d91e10a2a9d)</span></li>
<li>autotests/fakeplugin.json <span style="color: grey">(de4aed91f7b81af49f60a5bb4fed4c9c88807022)</span></li>
<li>autotests/kplugininfotest.cpp <span style="color: grey">(d99b92a9523b97ee4a65f0a40c737c46275caeb6)</span></li>
<li>autotests/kservicetest.h <span style="color: grey">(380cf7b2df7fda7e2df0f37bdc0ee8a16971fc03)</span></li>
<li>autotests/kservicetest.cpp <span style="color: grey">(2c71331903eab6de6b6dcd440439c697e87f2a4a)</span></li>
<li>src/services/kplugininfo.h <span style="color: grey">(7b98576a17ba4bb3b8e283e56c6cb1b2ff7fec73)</span></li>
<li>src/services/kplugininfo.cpp <span style="color: grey">(56dc0b43036a2a49804ff799360c29c2121dda54)</span></li>
<li>src/services/kservice.cpp <span style="color: grey">(3639a2875e5dbaefc6511d36d7b7f0fb7697ea74)</span></li>
<li>src/services/kservice_p.h <span style="color: grey">(bf59f3850d7ff2343526973794d5a4605a8f7934)</span></li>
<li>src/sycoca/ksycoca.cpp <span style="color: grey">(32d1689ad9cd01d3a8adb5123a1848278714ca95)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124633/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>