<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124634/">https://git.reviewboard.kde.org/r/124634/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Marco Martin</p>
<br />
<p>On August 5th, 2015, 9:45 p.m. UTC, Sebastian Kügler wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Sebastian Kügler.</div>
<p style="color: grey;"><i>Updated Aug. 5, 2015, 9:45 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Filter applets by formFactor</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch allows to filter the loaded Plasmoids by formFactor. It uses
a property of host, and passes this down to the PlasmoidProtocol, which
then decides based on formFactor whether or not to show a Plasmoid.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The value for FormFactor can be changed from QML.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch requires https://git.reviewboard.kde.org/r/124632/ to work
correctly, but it won't hide any applet until then. It's safe to use even
without above patch.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">REVIEW:</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tried "desktop" and "handset" Formfactor to show / hide the mobile battery applet in the systray.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/systemtray/package/contents/ui/main.qml <span style="color: grey">(0d01654bb264f79010ef15418e0e4c5498a4661c)</span></li>
<li>applets/systemtray/plugin/host.h <span style="color: grey">(c7ffac7043ac8e668ab582d3508eb4facbe252e8)</span></li>
<li>applets/systemtray/plugin/host.cpp <span style="color: grey">(dfb294a9574685060a80afe9a26665c7f61c15b8)</span></li>
<li>applets/systemtray/plugin/protocols/plasmoid/plasmoidprotocol.h <span style="color: grey">(2776c2fa40e05c6c6aa2dcfa31f37033712a4d36)</span></li>
<li>applets/systemtray/plugin/protocols/plasmoid/plasmoidprotocol.cpp <span style="color: grey">(66d8a6a48a1ad5bce3fc27e2e83b3a26be3e4f6e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124634/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>