<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Sat, Aug 1, 2015 at 8:27 PM, David Edmundson <span dir="ltr"><<a href="mailto:david@davidedmundson.co.uk" target="_blank">david@davidedmundson.co.uk</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">



 <div>
  <div style="font-family:Verdana,Arial,Helvetica,Sans-Serif">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border:1px #c9c399 solid;border-radius:6px">
    <tbody><tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124580/" target="_blank">https://git.reviewboard.kde.org/r/124580/</a>
     </td>
    </tr>
   </tbody></table>
   <br>




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border:1px #888a85 solid;border-radius:6px">
 <tbody><tr>
  <td>

<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>










<div style="margin-top:1.5em">
 <b style="color:#575012;font-size:10pt">Repository: </b>
plasma-desktop
</div>


<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
 <tbody><tr>
  <td>
   <pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">For some reason we have two IconDialog's exported to QML.

One in KDeclarative, one in Plasma-Frameworks/platformcomponents.

The one in plasmacomponents performs an exec() in the main thread from
QML which is a very bad idea. the one in kdeclarative is good.

BUG: 350864</pre>
  </td>
 </tr>
</tbody></table>


<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
 <tbody><tr>
  <td>
   <pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p style="padding:0;margin:0;line-height:inherit;white-space:inherit">Changed my activity icon.</p></pre>
  </td>
 </tr>
</tbody></table>


<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">

 <li>desktoppackage/contents/activitymanager/ActivityCreationDialog.qml <span style="color:grey">(102926bf57f21f33e2c45ff160ddfc68dd028dde)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124580/diff/" style="margin-left:3em" target="_blank">View Diff</a></p>






  </td>
 </tr>
</tbody></table>



  </div>
 </div>


<br>_______________________________________________<br>
Plasma-devel mailing list<br>
<a href="mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/plasma-devel" rel="noreferrer" target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br>
<br></blockquote></div><br></div><div class="gmail_extra">Can we deprecate the one in Plasma Framework?</div><div class="gmail_extra"><br></div><div class="gmail_extra">Aleix</div></div>