<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124585/">https://git.reviewboard.kde.org/r/124585/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I like the idea.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Would it be better UI if we moved "New Session" into the "Change Session" in the current lock screen so that they're both identical?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">/IF/ we did do that then we can re-use the QML file completely; and probably even launch kscreenlocker_greet from ksmserver just with an extra arg to go directly to the switch session page?</p></pre>
<br />
<p>- David Edmundson</p>
<br />
<p>On August 1st, 2015, 10:38 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and KDE Usability.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Aug. 1, 2015, 10:38 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This adds a user switcher dialog borrowing elements from the lock screen and log out dialog. I never understood why KRunner was used for that.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It is not yet hooked up to the system (would make KRunner's "switchUser" interface forward that to KSMServer so everybody using it (eg. kickoff) would continue to work without adjustments). To test it run qdbus org.kde.ksmserver /KSMServer openSwitchUserDialog</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">When it opens it defaults to "New Session", from an interaction POV the list view behaves like the one on the lock screen.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It locks the screen when switching users only when the user has enabled the lock screen (might need a separate option for that?) That unconditional locking on session switching has turned out to be a major annoyance.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks pretty, switching to a new or existing session works.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Btw, weren't we able to click outside the dialog to dismiss it in 4.x? Seems broken for the logout dialog as well.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/CMakeLists.txt <span style="color: grey">(a0c8852)</span></li>
<li>ksmserver/org.kde.KSMServerInterface.xml <span style="color: grey">(3680ed7)</span></li>
<li>ksmserver/server.h <span style="color: grey">(2176aa1)</span></li>
<li>ksmserver/server.cpp <span style="color: grey">(b73b792)</span></li>
<li>ksmserver/switchuserdialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksmserver/switchuserdialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lookandfeel/contents/components/UserList.qml <span style="color: grey">(778d8ea)</span></li>
<li>lookandfeel/contents/components/UserSelect.qml <span style="color: grey">(007a118)</span></li>
<li>lookandfeel/contents/userswitcher/UserSwitcher.qml <span style="color: grey">(e69de29)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124585/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/01/03dc2669-bee4-43a5-be11-350ba72417a6__fancyswitchuser1.jpg">User switcher</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/01/bb4d5a64-2ac5-4f61-9fd7-38d222a1f74f__fancyswitchuser2.jpg">User switcher with icons</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>