<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124374/">https://git.reviewboard.kde.org/r/124374/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 21st, 2015, 4:20 p.m. UTC, <b>Andrew Lake</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Very nice. A couple questions:
1. Are the inline selectiion handles grab-able? I assume yes.
2. Does this automatically appear when a selection is made or on right-click? I assume the former.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It would eventually be nice to have this solution for main application controls as well (or at least QtQuick controls)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Anyway, quite nice.</p></pre>
</blockquote>
<p>On July 21st, 2015, 4:24 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's purely for touchscreen interfaces, on a desktop system none of this would appear/have effect: the menu would be a normal qmenu and only appear on right click.
so the blue things are draggable. The thing is supported by qtquickcontrols out of the box, but is style-dependent and the upstream qstyle based style doesn't support it</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Very cool, thanks.</p></pre>
<br />
<p>- Andrew</p>
<br />
<p>On July 21st, 2015, 9:35 a.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated July 21, 2015, 9:35 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This depends from https://codereview.qt-project.org/#/c/121659/
provides the needed elements for touch based text selection and inline (no separate window) menu for cut/copy/paste</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/plasmastyle/CursorHandleStyle.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/declarativeimports/plasmastyle/EditMenuTouch.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/declarativeimports/plasmastyle/SelectionHandleStyle.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/declarativeimports/plasmastyle/TextAreaStyle.qml <span style="color: grey">(114c322)</span></li>
<li>src/declarativeimports/plasmastyle/TextFieldStyle.qml <span style="color: grey">(635c938)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124374/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/16/7fb4e7da-e705-4bd1-b084-1a69145a0bc2__snapshot1.png">snapshot1.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>