<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124340/">https://git.reviewboard.kde.org/r/124340/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">the icons are not that explanatory indeed, but better to use the right icon names anyways</p></pre>
<br />
<p>- Marco Martin</p>
<br />
<p>On July 13th, 2015, 6:20 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and KDE Usability.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated July 13, 2015, 6:20 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
muon
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This makes it use the Plasma theme's icon for the updater.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Works. I'm not too happy with the icons, though, perhaps VDG should improve them a bit.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The "no updates" icon isn't really recognizable and looks similar to the notification icon above it. The "there are updates" icon looks sort of okay, the "security updates" icon should perhaps be red/orange so it stands out. There's also a dedicated security updates icon but it has a padlock in it and looks like something has to be unlocked rather than about updates.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>notifier/MuonNotifier.cpp <span style="color: grey">(e3ca913)</span></li>
<li>notifier/plasmoid/contents/ui/main.qml <span style="color: grey">(5e32b24)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124340/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/13/024917b4-d9ab-4584-bc3a-333d2d47487b__updates-none.png">No updates</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/13/99678ec4-ebb9-49de-93e0-fdb990660fd9__updates-some.png">Updates available</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/13/8f641ed9-0012-4384-b3c6-9ac7ea6a1b7e__updates-important.png">Security updates</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>