<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/102983/">https://git.reviewboard.kde.org/r/102983/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can you please discard this review? libbluedevil is not used in recent Plasma release (replaced with bluez-qt which have support for rfkill), and there won't be any more KDE4 nor Plasma 5.2.x releases.</p></pre>
<br />
<p>- David Rosca</p>
<br />
<p>On July 11th, 2015, 8:43 p.m. UTC, Rüdiger Sonderfeld wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and Solid.</div>
<div>By Rüdiger Sonderfeld.</div>
<p style="color: grey;"><i>Updated July 11, 2015, 8:43 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libbluedevil
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">rfkill is a subsystem of the Linux Kernel to disable radio transmitters (including Bluetooth). This patch adds support for rfkill to libbluedevil. An interface is added to the Manager class.
rfkill support is important because gnome uses rfkill to deactivate bluetooth. Therefore if bluetooth is currently disabled in the gnome-control-center it can not be used by kde. With this patch the proper API to reenable bluetooth is provided.
Disabling bluetooth with rfkill has the advantage that some computers switch off the bluetooth LED. Which does not happen (at least on my Thinkpad) if it's just powered off (as kde does at the moment).
rfkill can also detect if bluetooth has been deactivated by a hardware switch.
btw. please mark https://gitorious.org/libbluedevil/libbluedevil as obsolete and update http://projects.ufocoders.com/projects/libbluedevil/wiki. I used the old gitorious code base at first.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I added a test to bluedeviltest and it works for me.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>bluedevil/bluedevilmanager.h <span style="color: grey">(0386b8e)</span></li>
<li>bluedevil/bluedevilmanager.cpp <span style="color: grey">(594d3bd)</span></li>
<li>bluedevil/test/bluedeviltest.cpp <span style="color: grey">(2d3d0e2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/102983/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>