<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124234/">https://git.reviewboard.kde.org/r/124234/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Code wise this is fine.
Assuming VDG are giving this a +1
ship it!</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124234/diff/2/?file=382480#file382480line250" style="color: black; font-weight: bold; text-decoration: underline;">applets/systemtray/plugin/host.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void Host::setCategoryShown(int cat, bool shown)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">227</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="n">d</span><span class="o">-></span><span class="n">forcedHiddenItems</span><span class="p">.</span><span class="n">contains</span><span class="p">(</span><span class="n">task</span><span class="o">-></span><span class="n">taskId</span><span class="p">())</span> <span class="o">&&</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">238</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span><span class="hl"> </span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">d</span></span><span class="o"><span class="hl">-></span></span><span class="n"><span class="hl">showAllItems</span></span><span class="hl"> </span><span class="o"><span class="hl">||</span></span> <span class="p">(</span><span class="o">!</span><span class="n">d</span><span class="o">-></span><span class="n">forcedHiddenItems</span><span class="p">.</span><span class="n">contains</span><span class="p">(</span><span class="n">task</span><span class="o">-></span><span class="n">taskId</span><span class="p">())</span> <span class="o">&&</span></pre></td>
</tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">228</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">(</span><span class="n">d</span><span class="o">-></span><span class="n">forcedShownItems</span><span class="p">.</span><span class="n">contains</span><span class="p">(</span><span class="n">task</span><span class="o">-></span><span class="n">taskId</span><span class="p">())</span> <span class="o">||</span> <span class="n">d</span><span class="o">-></span><span class="n">showTask</span><span class="p">(</span><span class="n">task</span><span class="p">)))</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">239</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">(</span><span class="n">d</span><span class="o">-></span><span class="n">forcedShownItems</span><span class="p">.</span><span class="n">contains</span><span class="p">(</span><span class="n">task</span><span class="o">-></span><span class="n">taskId</span><span class="p">())</span> <span class="o">||</span> <span class="n">d</span><span class="o">-></span><span class="n">showTask</span><span class="p">(</span><span class="n">task</span><span class="p">)))<span class="hl">)</span></span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Given this massive if statement occurs 4 times I'd like a:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">bool isTaskShown(Task*) const;</p></pre>
</div>
</div>
<br />
<p>- David Edmundson</p>
<br />
<p>On July 2nd, 2015, 9:23 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and KDE Usability.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated July 2, 2015, 9:23 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=349812">349812</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This adds an option to always show all system tray icons and never collapse them into the popup. I've seen a couple of people already requesting this.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Enabled and disabled the option and tray icons along with the arrow came and went, started music player and media controller properly appeared and disappeared, started and quit KMail and its icon properla appeared and disappeared with both options.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/systemtray/package/contents/config/main.xml <span style="color: grey">(8e8996c)</span></li>
<li>applets/systemtray/package/contents/ui/ConfigEntries.qml <span style="color: grey">(8b6ec28)</span></li>
<li>applets/systemtray/package/contents/ui/TaskDelegate.qml <span style="color: grey">(221c6e7)</span></li>
<li>applets/systemtray/package/contents/ui/main.qml <span style="color: grey">(e794d1c)</span></li>
<li>applets/systemtray/plugin/host.h <span style="color: grey">(bd9728b)</span></li>
<li>applets/systemtray/plugin/host.cpp <span style="color: grey">(5c897fa)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124234/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/50ae2a2e-8052-4d87-85c3-5ad8aa1da1f4__trayalways_dialog.png">Settings dialog (disabled)</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/d79b67e9-9950-4fb7-97a9-b89b93caeeb7__trayalways_dialogenabled.png">Settings dialog (enabled)</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/1b122131-88b0-410c-8532-8dbb74cad5db__trayalways_disabled.png">System Tray (disabled)</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/3668a352-65c1-4d34-94d8-bc7141ce784e__trayalways_enabled.png">System Tray (enabled)</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/cf2a921d-a4e3-4e94-b19d-3c6b0d3f3335__trayalways_dialogbetter.png">Better dialog layout</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/57d2c759-97f8-4c44-9f00-c08558de9a9d__trayalways_passive.png">Dim System Tray</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>