<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123992/">https://git.reviewboard.kde.org/r/123992/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 4th, 2015, 10:33 p.m. UTC, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">5.4 or 5.3.2?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've noticed that a bunch of smaller things could be improved, though they might well be in the original code already, so can be pushed upstream independently.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm OK with shipping this as-is, since this is really the wrong place to fix the fallout I've noticed, so if you feel comfy with it as-is (and will take care of removing the copy again once upstream has merged the changes), then go ahead and ship it.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Most importantly: Fixing crashers is good, and that's why it should go in quickly. Thanks for looking into this.</p></pre>
</blockquote>
<p>On June 5th, 2015, 10:50 a.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm wanting to go for 5.3.2</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's in a branch in davidedmundson/newdbusmenuqt if people want to give it a spin.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">your smaller comments look sensible; if we want to drop Qt4 upstream. Which I don't know about. I'll ask and put them in upstream's review too.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I missed that window because I forgot.
Pushed for 5.4. Implemented most your comments.</p></pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 4th, 2015, 10:33 p.m. UTC, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/123992/diff/1/?file=378706#file378706line37" style="color: black; font-weight: bold; text-decoration: underline;">dataengines/statusnotifieritem/libdbusmenuqt/dbusmenushortcut_p.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">37</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">{</span> <span class="p">{</span><span class="s">"Meta"</span><span class="p">,</span> <span class="s">"Super"</span><span class="p">},</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">could be wrapped in more efficient ctors (QL1S, QStringLiteral)</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">they're char*s</p></pre>
<br />
<p>- David</p>
<br />
<p>On June 3rd, 2015, 4:03 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated June 3, 2015, 4:03 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This contains a temporary fork of the dbusmenu-qt importer, with the main paths fixed. Also fixes some leaks</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No loner has a stupid event loop. This fixes ~5 crash reports we've had.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Submitted to upstream, but they're not the fastest and it has to be an API break.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dataengines/statusnotifieritem/CMakeLists.txt <span style="color: grey">(e639ee351a1cc6ad0b4448bd0feadc7af0d7984d)</span></li>
<li>dataengines/statusnotifieritem/libdbusmenuqt/README <span style="color: grey">(PRE-CREATION)</span></li>
<li>dataengines/statusnotifieritem/libdbusmenuqt/dbusmenuimporter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>dataengines/statusnotifieritem/libdbusmenuqt/dbusmenuimporter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>dataengines/statusnotifieritem/libdbusmenuqt/dbusmenushortcut_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>dataengines/statusnotifieritem/libdbusmenuqt/dbusmenushortcut_p.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>dataengines/statusnotifieritem/libdbusmenuqt/dbusmenutypes_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>dataengines/statusnotifieritem/libdbusmenuqt/dbusmenutypes_p.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>dataengines/statusnotifieritem/libdbusmenuqt/utils.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>dataengines/statusnotifieritem/libdbusmenuqt/utils_p.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123992/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>