<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124246/">https://git.reviewboard.kde.org/r/124246/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Juli 4th, 2015, 9:01 nachm. UTC, <b>Heiko Tietze</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Didn't test the workflow so just about the screenshot. Alignment looks somewhat strange. According https://techbase.kde.org/Projects/Usability/HIG/Alignment the right position is left for the longest label and all other to its right edge. Furthermore the checkbox as introduction to the function is weird. If non-custom means black you could simply omit the checkbox. Probably you adjust b/w in respect to the background. Hence the color would rather fit an indented child below the checkbox. I wonder why font size and color can be set but no other option. Either it's too much (who needs to set color to green or change the default font) or not enough (why not have comic font).</p></pre>
</blockquote>
<p>On Juli 5th, 2015, 11:03 vorm. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Formatting options like bold, italic, and the like are set in the applet using the formatting buttons similar to a word processor and not globally. Font size is a must (I often use huge sticky notes as really important reminders), not sure about font color (given you can already achieve emphasis by changing the note color) and font family.</p></pre>
</blockquote>
<p>On Juli 5th, 2015, 2:32 nachm. UTC, <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I do agree with Heiko that being able to set font color and size, but not font family, is really odd.
Font style (bold etc.) should indeed not be set globally because they are used for emphasis. Font family, on the other hand, are as much of a stylistic preference as color and size.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As for the "I want huge notes for important stuff": Why not adjusting the size automatically so that the text always fills the whole widget?
That way you could use huge <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">notes</em> (as opposed to normal-sized notes with huge text) for important stuff. Of course the font size should never shrink below minimum readable size.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As for the font color: I'd rather vote for adjusting it automatically with the note color (possibly allowing e.g. "Black on yellow" and "Red on yellow" as separate options if we think both make sense). That would also ensure could contrast.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So, long story short: I am against offering any font settings for the Plasmoid as such.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why not adjusting the size automatically so that the text always fills the whole widget?</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Because I might place a lot of stuff into a note or just little. I want to have the control over the sizing to not have it look odd when I have 10 sticky notes, all with different size. I do make them huge if I want huge size but I wouldn't want an auto size.</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As for the font color: I'd rather vote for adjusting it automatically with the note color</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The font is black (well, very dark gray) by default and white for the black sticky note. </p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">possibly allowing e.g. "Black on yellow" and "Red on yellow" as separate options</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">?</p></pre>
<br />
<p>- Kai Uwe</p>
<br />
<p>On Juli 4th, 2015, 11:43 vorm. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and KDE Usability.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Juli 4, 2015, 11:43 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch adds the following improvements to the sticky notes applet:</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">A config dialog with previews of the individual colors, the ability to change the font size, and font color - are there any other important options the 4.x one had?</p>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ctrl+Mousewheel to change font size, I always used this "feature" in 4.x and was disappointed that it would not actually save the font size</p>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Focus the input field when expanding the applet (eg. when it is in a panel, click the note, start typing)</p>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Drag and drop support so you can now drag files and text snippets into the sticky note</p>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Better keyboard navigation: you can now place a sticky note in your panel, assign a shortcut to it, press it, note down your thoughts, and close the note again</p>
</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Changing the font size from the config dialog and mousewheeling seems to work without screwing up your existing formatting.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Unfortunately the config dialog is quite difficult to get to since right clicking the text area yields the standard copy/paste menu and I failed to manually add another item for the applet config there</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/notes/package/contents/config/config.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/notes/package/contents/config/main.xml <span style="color: grey">(596dfc0)</span></li>
<li>applets/notes/package/contents/ui/configAppearance.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/notes/package/contents/ui/main.qml <span style="color: grey">(1f1022c)</span></li>
<li>applets/notes/plugin/documenthandler.h <span style="color: grey">(41cf704)</span></li>
<li>applets/notes/plugin/documenthandler.cpp <span style="color: grey">(79c276e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124246/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/04/1d244f32-79e6-435c-a906-1acddede0aa3__stickylove3.png">Config dialog</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>