<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124234/">https://git.reviewboard.kde.org/r/124234/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On juli 3rd, 2015, 3:39 a.m. UTC, <b>Andrew Lake</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yeah, let's not bother with the dimming. It just introduces another visualization for a state that's ostensibly disabled. Hide or no hide, there is no try. :-)</p></pre>
</blockquote>
<p>On juli 3rd, 2015, 1:33 p.m. UTC, <b>Bart Schouten</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi, xen here. Hope this works. Doing everything on a smartphone, kinda slow.
I was writing that the new layout looks better indeed. I would still suggest putting the text+checkbox below the list, but make sure it stays on screen (ie. scroll the list not the entire pane). By putting it below it kinda summarizes the list and gets the aattention it deserves. Also, the wording. I'd suggest wording it negatively. Ie. not "Always show all icons" but "Don't hide unused icons". This makes it congruent with the user's perspective, which is that generally stuff is hidden (not shown). Give it a try, it will read much easier and be easier comprehensible. To reframe "hiding icons" is the familiar proposition, "showing" isn't. (Show what? What icons? Icons are already shown aren't they? Oh - the /hidden/ icons!) So that's what the user is after if she comes here.</pre>
</blockquote>
<p>On juli 3rd, 2015, 1:41 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Our HIG say that CheckBoxes must be postive, ie. "enable" something not "disable" or "don't"</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Then you make it another checkbox that is checked by default, which reads "Group icons into a hidden icon popup." which also references the user's POV and which the user needs to /deselect/ to get rid of the default behaviour. That might be even better indeed. But this checkbox you keep at the top because it no longer summarizes but rather presents.
But you want the status quo to be represented in some way in the wording.</pre>
<br />
<p>- Bart</p>
<br />
<p>On juli 2nd, 2015, 9:23 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and KDE Usability.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated jul 2, 2015, 9:23 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=349812">349812</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This adds an option to always show all system tray icons and never collapse them into the popup. I've seen a couple of people already requesting this.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Enabled and disabled the option and tray icons along with the arrow came and went, started music player and media controller properly appeared and disappeared, started and quit KMail and its icon properla appeared and disappeared with both options.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/systemtray/package/contents/config/main.xml <span style="color: grey">(8e8996c)</span></li>
<li>applets/systemtray/package/contents/ui/ConfigEntries.qml <span style="color: grey">(8b6ec28)</span></li>
<li>applets/systemtray/package/contents/ui/TaskDelegate.qml <span style="color: grey">(221c6e7)</span></li>
<li>applets/systemtray/package/contents/ui/main.qml <span style="color: grey">(e794d1c)</span></li>
<li>applets/systemtray/plugin/host.h <span style="color: grey">(bd9728b)</span></li>
<li>applets/systemtray/plugin/host.cpp <span style="color: grey">(5c897fa)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124234/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/50ae2a2e-8052-4d87-85c3-5ad8aa1da1f4__trayalways_dialog.png">Settings dialog (disabled)</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/d79b67e9-9950-4fb7-97a9-b89b93caeeb7__trayalways_dialogenabled.png">Settings dialog (enabled)</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/1b122131-88b0-410c-8532-8dbb74cad5db__trayalways_disabled.png">System Tray (disabled)</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/3668a352-65c1-4d34-94d8-bc7141ce784e__trayalways_enabled.png">System Tray (enabled)</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/cf2a921d-a4e3-4e94-b19d-3c6b0d3f3335__trayalways_dialogbetter.png">Better dialog layout</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/57d2c759-97f8-4c44-9f00-c08558de9a9d__trayalways_passive.png">Dim System Tray</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>