<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124005/">https://git.reviewboard.kde.org/r/124005/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 4th, 2015, 9:59 a.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124005/diff/1/?file=378756#file378756line43" style="color: black; font-weight: bold; text-decoration: underline;">applets/digital-clock/package/contents/config/main.xml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">43</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nt"><default></span>false<span class="nt"></default></span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why not make it default?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yours looks much more beautiful and tidy than the old 4.x version which always confused me.</p></pre>
</blockquote>
<p>On June 4th, 2015, 5:04 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">"Simple by default, powerful when needed" ;) It's not a feature everyone wants/needs, but it's there when they do.</p></pre>
</blockquote>
<p>On June 4th, 2015, 7:27 p.m. UTC, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">IMO, it should default to on, without an option. Weeknumbers are a pretty basic calendar feature, and most people will probably not even bother looking at the config dialogue, especially since it has never been there. It's simply a missing feature which we now add, it doesn't need to be optional.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's not "powerful when needed", it's "powerful when the user happens to find the option in the config dialog" this way, it's advertised nowhere that this feature is now available.</p></pre>
</blockquote>
<p>On June 4th, 2015, 7:31 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've never used them. I'm with Martin.</p></pre>
</blockquote>
<p>On June 4th, 2015, 7:32 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'd say bring in the usability team :)</p></pre>
</blockquote>
<p>On June 4th, 2015, 7:40 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">effectively done: https://bugs.kde.org/show_bug.cgi?id=299174#c13
comments 13 && 14 are Heiko and Thomas</p></pre>
</blockquote>
<p>On June 4th, 2015, 7:41 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ok then</p></pre>
</blockquote>
<p>On June 4th, 2015, 7:51 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> It's not "powerful when needed", it's "powerful when the user happens to find the option in the config dialog"
But that's the case with about /all/ our "powerful when needed" features, isn't it? How else would you do "powerful when needed"? And it shouldn't be decoupled from the "Simple by default" part, which this really is.
> it's advertised nowhere that this feature is now available.
Come on now, we add manymanymany new features every release, portion of which is also off by default. That's what release notes are for.
--
Anywho, from the aformentioned bug, comment by Thomas Pfeiffer:
"A configuration option would definitely be helpful here, because the week number is useless for many people, but essential for many others: In many companies, week numbers are used regularly for time planning, but for people not working in such companies they're indeed pretty much meaningless."
One more interesting comment by someone:
"I can not understand why you can configure the bejesus out of the clock, but the calendar is a immutable monolithic totem to somebody's preferred format." ...to which I have to really agree.</pre>
</blockquote>
<p>On June 4th, 2015, 7:55 p.m. UTC, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm ok with that, I trust our usability people. In my perception, weeknumbers are an essential calendar feature, but apparently they're less used outside of "my world". :)</p></pre>
</blockquote>
<p>On June 4th, 2015, 8:13 p.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">While I have never worked in a company where week numbers matter, it's actually the most important feature I need a calender for. Maybe it's a cultural thing, but week numbers are pretty common in Germany - we even used them in school. So IMHO our usability team is wrong here.</p></pre>
</blockquote>
<p>On June 4th, 2015, 8:17 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">On contrary in Czech republic, many people even don't know that such thing exists at all. In here it's quite useless piece of information (unless in corporate environment).</p></pre>
</blockquote>
<p>On June 4th, 2015, 8:19 p.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">so it is a cultural thing - which means a config option makes sense. The question is what way it should be. For users who need it and expect it: will they find it? For users not needing it: will it hurt being shown?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Every paper calender in Germany has the week number, so not having it seems from my German perspective extremely broken.</p></pre>
</blockquote>
<p>On June 4th, 2015, 8:26 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't think we should be arguing this - it can be different per country and we'll never agree on it. And we have estabilished "simple by default, powerful when needed" vision kindofthing. So I think we should be following that. For many people (and I dare to say 50%) week numbers are "powerful" (ie. useless). For those that do need it, check that checkbox and be done.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">By the way, our clock does not show date by default and I do believe that date is actually way more important than week number.</p></pre>
</blockquote>
<p>On June 4th, 2015, 10:17 p.m. UTC, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Well, space is at a premium in the panel, so all kinds of assumptions that are true for the calendar do not hold in the panel.</p></pre>
</blockquote>
<p>On June 9th, 2015, 4:53 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In Italy is not much common in calendars at home, however in office environments without week numbers you're screwed. in office environments I think is also more globally needed, less regarding to the locale.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">so +1 to just enable it</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Martin K. has explained it quite well: A config option makes sense in cases where something is important for some people, but useless (or actually harmful) for others, and neither of the two groups is small enough to be irrelevant. Often config options are introduced as a workaround for bad design or to avoid a design choice, but this is the poster case for an option, because user needs actually differ between individuals.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Since Martin already quoted my opinion from over two years ago (which still stands), I don't have to repeat it.
We should not show a significant proportion of users a piece of information which they do not care about at all, without an option to hide it.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I do not agree with Sebas that only few users would even find the option, either. Most of those users who don't care about week numbers probably won't ever see that checkbox, which is exactly what we want. If, however, a user misses the week numbers, why would he or she <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">not</em> look if there is an option to turn it on before cursing KDE and uninstalling Plasma? And even if for some reason they wouldn't think of the possibility that there may be an option, why wouldn't they ask the search engine of their choice something like "plasma calendar week number"? In that case, of course, the first search result should be the release announcement that tells them that the option is there.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Whether week numbers should be on or off by default, however, is a slightly more complex matter, as it depends on the target audience. Plasma 5 has not yet decided who their target users are, which is quite a bad situation for such an important piece of software. If the Plasma team had agreed upon a primary target persona, the decision would be easy: If that persona uses Plasma in a work context, week numbers should be shown by default. If the persona uses it only privately, they should not be shown by default.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's been years since last time I used a paper calendar (and even more years since last time I used a paper calendar intended for home use, not office/work use, which is what would be relevant here), so I can neither confirm nor deny the statement that all of them have week numbers.
I have never met a person who said "Hey, let's book our holidays during week number 31!", however, or "Oh, I have to file my tax statement by the end of week 22!". That's not to say those people don't exist, but if they made up a large percentage of the population, I'm sure I'd have met some of them.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So, this shows that it's time the Plasma team decides on a primary target persona, and fast. Without a target audience, flipping a coin would be as good a decision process as any.</p></pre>
<br />
<p>- Thomas</p>
<br />
<p>On June 4th, 2015, 9:55 a.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated June 4, 2015, 9:55 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">One of the most requested features for Plasma5. This is the applet's part (basically just the config).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See https://git.reviewboard.kde.org/r/124004/ for part 1 and screenshot.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Another part will be the (standalone) Calendar applet.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/digital-clock/package/contents/config/main.xml <span style="color: grey">(5237160)</span></li>
<li>applets/digital-clock/package/contents/ui/CalendarView.qml <span style="color: grey">(b5a080b)</span></li>
<li>applets/digital-clock/package/contents/ui/configAppearance.qml <span style="color: grey">(669b1cc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124005/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>