<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124037/">https://git.reviewboard.kde.org/r/124037/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Simple cancel without a countdown makes not much sense. Do I have bone-breaking 10sec or more? Or is it the small progressbar right hand? It would be good to have some text as well. By the way: ellipsis in this widget are not so good (guess the full text is shown in a tooltip). I'd recommend "Battery-low condition" as title plus sub text "remaining: 2%/~10min" and "shutdown in: 10s" with the option to cancel, if relevant.
Does the safety shutdown pops-up again or is it the user's duty now to care about saving stuff? I'm not sure if overriding safety features is a good idea in general.</p></pre>
<br />
<p>- Heiko Tietze</p>
<br />
<p>On Juni 8th, 2015, 5:30 nachm. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, Solid and KDE Usability.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Juni 8, 2015, 5:30 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
powerdevil
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">To prevent David from eventually breaking his bones tumbling down the stairs rushing for his AC adapter, this adds a "Cancel" button to the battery critical notification that allows to cancel the timeout for automatic suspend/shutdown.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Got a "Cancel" button only when it was configured to do something, clicking the button from both popup and history cancelled the timeout. (Unfortunately the notification doesn't fit into the popup at all now)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>daemon/powerdevilcore.h <span style="color: grey">(50e6a50)</span></li>
<li>daemon/powerdevilcore.cpp <span style="color: grey">(e90a960)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124037/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/06/07/f99c0164-4436-462f-974b-ddc5df0ce500__powerdevilcanceltimeout.png">Notification with close button</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>