<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124039/">https://git.reviewboard.kde.org/r/124039/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- David Edmundson</p>
<br />
<p>On June 8th, 2015, 10:01 a.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and KDE Usability.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated June 8, 2015, 10:01 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=342934">342934</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=348154">348154</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Only the background contrast provides real contrast for the background, the blur doesn't improve readability that much, so when background contrast is disabled we use the less transparent svgs instead. This makes the panels look similarly white (so no more embarrasing reviews on news websites) to the regular theme and significantly improves readability.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Blur: off, Contrast: off -> opaque
Blur: on, Contrast: off -> opaque (previously transparent)
Blur: off, Contrast: on -> transparent, good readability (previously opaque)
Blur: on, Contrast: on -> transparent, good readability</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The regular SVG could become slightly transparent though, it looks like the "opaque" variant that is used when compositing is disabled.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">With Breeze Dark transparency without contrast isn't that strong but still readability is significantly improved.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasma/private/theme_p.h <span style="color: grey">(68336f0)</span></li>
<li>src/plasma/private/theme_p.cpp <span style="color: grey">(f64265b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124039/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/06/08/a2f7a225-b0f9-4e91-ac42-5d58cd4318f6__backgroundcontraston.png">Contrast enabled</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/06/08/9e6b0d51-f58a-483e-bbf5-fee942739f44__backgroundcontrastoffbefore.png">Contrast off (before)</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/06/08/5c609063-bbfc-4d8d-b4dd-220154523415__backgroundcontrastoffafter.png">Contrast off (after)</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>