<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123789/">https://git.reviewboard.kde.org/r/123789/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 14th, 2015, 2:19 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/123789/diff/3/?file=369034#file369034line126" style="color: black; font-weight: bold; text-decoration: underline;">applets/systemtray/package/contents/ui/main.qml</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">126</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">//</span><span class="cs">NOTE</span><span class="c1">: again workaround: we want to make sure a QVariant(QStringList) is assigned to plasmoid.configuration.extraItems, *not* a QJSValue, causing</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">is it this thing?
http://tsdgeos.blogspot.co.uk/2015/02/qt-54-qml-c-qvariant-issues.html</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Could you test if this https://paste.kde.org/pgu5pnukc on kdeclarative fixes it?</p></pre>
</blockquote>
<p>On May 14th, 2015, 2:35 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">seems it's that one.
i tried your patch, but with the qml</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"> if (extraItems.length > 0) {
plasmoid.configuration.extraItems = plasmoid.configuration.extraItems.concat(extraItems);
}
if (newKnownItems.length > 0) {
lasmoid.configuration.knownItems = plasmoid.configuration.knownItems.concat(knownItems);
}
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">it still breaks the saved value</p></pre>
</blockquote>
<p>On May 14th, 2015, 2:36 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">i mean,
if (extraItems.length > 0) {
plasmoid.configuration.extraItems = plasmoid.configuration.extraItems.concat(extraItems);
}
if (newKnownItems.length > 0) {
plasmoid.configuration.knownItems = plasmoid.configuration.knownItems.concat(newKnownItems);
}</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">but yeah, still broken</p></pre>
</blockquote>
<p>On May 14th, 2015, 3:02 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">even more fun, this what a debug in ConfigPropertyMapPrivate::writeConfigValue says
qDebug()<<key<<value<<value.value<QJSValue>().toVariant();</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">becomes:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">"knownItems" QVariant(QJSValue, ) QVariant(QVariantList, (QVariant(QStringList, ("", "org.kde.plasma.networkmanagement", "org.kde.muonnotifier", "org.kde.ktp-contactlist", "org.kde.plasma.clipboard", "org.kde.plasma.notifications", "org.kde.plasma.battery", "org.kde.plasma.printmanager", "org.kde.plasma.devicenotifier", "org.kde.plasma.bluetooth", "org.kde.plasma.mediacontroller")) , QVariant(QString, "org.kde.phone.notifications") ) )</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">so, like javascript thinks plasmoid.configuration.knownItems is not an array, doing a concat over this creates an array of two items, the first the full content it used to have, the second the new values.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It also suggests your patch to ConfigPropertyMapPrivate is correct, there is just also another problem on top of that one ;)</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">in fact with your patch, the following code works
if (newExtraItems.length > 0) {
plasmoid.configuration.extraItems = plasmoid.configuration.extraItems.slice().concat(newExtraItems);
}
if (newKnownItems.length > 0) {
plasmoid.configuration.knownItems = plasmoid.configuration.knownItems.slice().concat(newKnownItems);
}
like, after slice(), the thing is transformed from something that kinda looks like an array to a proper array</p></pre>
<br />
<p>- Marco</p>
<br />
<p>On May 14th, 2015, 11:20 a.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated May 14, 2015, 11:20 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=345872">345872</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">if new plasmoids are installed that are systray enabled and enabled by default, automatically add them, unless they were disabled explicitly. This solves a problem distributions seem to add while updating to new plasma releases.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">obtain this by keeping both a list of explicitly enabled stuff and all the already known stuff</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">it does horrible things with arrays, that's due to some weird sideeffects of having qstringlists as properties, of which we'll have to pay close attention to</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/systemtray/package/contents/config/main.xml <span style="color: grey">(2967dba)</span></li>
<li>applets/systemtray/package/contents/ui/main.qml <span style="color: grey">(fd59a14)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123789/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>