<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123626/">https://git.reviewboard.kde.org/r/123626/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 6th, 2015, 5:38 p.m. UTC, <b>Hrvoje Senjan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I would keep this for safety until Plasma 5.4 is released, then try to remove it again</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">First, sorry for being the bad cop, i'd just like to avoid any future (irreversible) problems, and that distros delivering monthly KF5 updates continue doing so in the future ;-)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Please don't remove anything ever, KF5 promises backward compatibility forever, not until $someotherproductversion...
Distros where assured over and over again in the famous thread that no-bugfix-only KF5 releases will be a good thing for everyone, and they should be treated as bugfix releases (same as we can update kdelibs to 4.14.99 with kde-workspace 4.11.99).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If a distro would release with $someotherproductversion-1, and update KF5 monthly they would get nice reports about broken desktops - and in principle all non-rolling distros won't deliver new feature releases for desktop and applications.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">the thing is the systray that would not show plasmoids anymore. all the rest should be 100% compatible.
but yeah, we can leave the desktop files in kservices5 for the time being.
we may eventually port the applets to a new install macro to have that file not installed</p></pre>
<br />
<p>- Marco</p>
<br />
<p>On May 6th, 2015, 5:21 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated May 6, 2015, 5:21 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this ports most of libplasma away from sycoca, using instead a combination of KPluginLoader and KPackage::PackageLoader instead (so eventually using their own little caches instead of the global sycoca cache)
a kservicetypetrader call is left in the loading of containmentactions since is the only way to make an older workspace still work, but is only a fallback, so containmentactions in plasma-workspace can be ported eventually as well</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">still needs a lot of testing, so far, with a master plasma-workspace notmal workspace functions seems fine</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">latest version still installs metadata files in kservices5. I would keep this for safety until Plasma 5.4 is released, then try to remove it again</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KF5PlasmaConfig.cmake.in <span style="color: grey">(dee79ca)</span></li>
<li>src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml <span style="color: grey">(be76a43)</span></li>
<li>src/plasma/applet.cpp <span style="color: grey">(2dda381)</span></li>
<li>src/plasma/containment.cpp <span style="color: grey">(7eabbb8)</span></li>
<li>src/plasma/containmentactions.cpp <span style="color: grey">(f24bdac)</span></li>
<li>src/plasma/dataengine.cpp <span style="color: grey">(4b3d671)</span></li>
<li>src/plasma/package.cpp <span style="color: grey">(4e0be88)</span></li>
<li>src/plasma/packagestructure.cpp <span style="color: grey">(b2686b6)</span></li>
<li>src/plasma/pluginloader.cpp <span style="color: grey">(0ce349a)</span></li>
<li>src/plasma/private/applet_p.cpp <span style="color: grey">(2cbfd06)</span></li>
<li>src/plasma/private/dataenginemanager.cpp <span style="color: grey">(b9c5d8e)</span></li>
<li>src/plasma/scripting/appletscript.h <span style="color: grey">(863d707)</span></li>
<li>src/plasma/scripting/dataenginescript.h <span style="color: grey">(f7ad3c2)</span></li>
<li>src/plasma/scripting/scriptengine.cpp <span style="color: grey">(cc407e7)</span></li>
<li>src/plasma/service.h <span style="color: grey">(b5d9b5a)</span></li>
<li>src/plasma/service.cpp <span style="color: grey">(3e9d852)</span></li>
<li>src/plasmapkg/plasmapkg.cpp <span style="color: grey">(d606365)</span></li>
<li>src/scriptengines/CMakeLists.txt <span style="color: grey">(f566406)</span></li>
<li>src/scriptengines/qml/CMakeLists.txt <span style="color: grey">(e7130db)</span></li>
<li>src/scriptengines/qml/plasmoid/appletinterface.cpp <span style="color: grey">(07ecb3d)</span></li>
<li>src/scriptengines/qml/plasmoid/containmentinterface.cpp <span style="color: grey">(c6986f2)</span></li>
<li>src/scriptengines/qml/plasmoid/declarativeappletscript.cpp <span style="color: grey">(24c39dd)</span></li>
<li>src/scriptengines/qml/plasmoid/wallpaperinterface.cpp <span style="color: grey">(a406d45)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123626/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>