<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123653/">https://git.reviewboard.kde.org/r/123653/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Mai 6th, 2015, 6 vorm. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">From experience with the show desktop feature and the problems when minimizing all windows I highly suggest to only minimize all windows. Don't even try to restore the minimized state when clicked again.</p></pre>
</blockquote>
<p>On Mai 6th, 2015, 10:20 vorm. UTC, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That is kind of the point of this feature -- it allows to click twice to "peek" at the desktop.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I know that there's a bunch of things that can ruin the state, that's what I'm catching in reset() (from that point on, we can't decide if the feature is active, so we reset its state and it can't unminimize all the windows again. We know that we can't get 100% synthetically clean behaviour (the whole showdesktop discussion), this plasmoid is there to emulate the old behaviour, and that means also unminimize.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That is kind of the point of this feature -- it allows to click twice to "peek" at the desktop.</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Well, that's what show desktop is for?</p></pre>
<br />
<p>- Kai Uwe</p>
<br />
<p>On Mai 6th, 2015, 12:16 vorm. UTC, Sebastian Kügler wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Sebastian Kügler.</div>
<p style="color: grey;"><i>Updated Mai 6, 2015, 12:16 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=346837">346837</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">New Minimize Windows Plasmoid</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This plasmoid allows to minimize windows on the current desktop. It does
not mess with the KWindowSystem::showingDesktop flag, just allows to hide
and show windows.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Used it for a while.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/CMakeLists.txt <span style="color: grey">(7ada7acad6796bcb18e0f408f00b3720a8df2393)</span></li>
<li>applets/minimizeall/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/minimizeall/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/minimizeall/package/contents/config/main.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/minimizeall/package/contents/ui/main.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/minimizeall/package/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/minimizeall/plugin/minimizeall.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/minimizeall/plugin/minimizeall.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/minimizeall/plugin/minimizeallplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/minimizeall/plugin/minimizeallplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/minimizeall/plugin/qmldir <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123653/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>