<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123664/">https://git.reviewboard.kde.org/r/123664/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Matthias Klumpp.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This apparently causes trouble, since DBusAddons is required by e.g.
appmenu, and not found in every environment.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We stumbled upon this in Tanglu, where plasma-workspace failed to build.
Relevant buildlog excerpts:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">-- Configuring done
CMake Warning (dev) at appmenu/CMakeLists.txt:24 (add_library):
Policy CMP0028 is not set: Double colon in target name means ALIAS or
IMPORTED target. Run "cmake --help-policy CMP0028" for policy details.
Use the cmake_policy command to set the policy and suppress this warning.
Target "kded_appmenu" links to target "KF5::DBusAddons" but the target was
not found. Perhaps a find_package() call is missing for an IMPORTED
target, or an ALIAS target is missing?
This warning is for project developers. Use -Wno-dev to suppress it.
CMake Warning (dev) at plasma-windowed/CMakeLists.txt:7 (add_executable):
Policy CMP0028 is not set: Double colon in target name means ALIAS or
IMPORTED target. Run "cmake --help-policy CMP0028" for policy details.
Use the cmake_policy command to set the policy and suppress this warning.
Target "plasmawindowed" links to target "KF5::DBusAddons" but the target
was not found. Perhaps a find_package() call is missing for an IMPORTED
target, or an ALIAS target is missing?
This warning is for project developers. Use -Wno-dev to suppress it.
CMake Warning (dev) at freespacenotifier/CMakeLists.txt:9 (add_library):
Policy CMP0028 is not set: Double colon in target name means ALIAS or
IMPORTED target. Run "cmake --help-policy CMP0028" for policy details.
Use the cmake_policy command to set the policy and suppress this warning.
Target "kded_freespacenotifier" links to target "KF5::DBusAddons" but the
target was not found. Perhaps a find_package() call is missing for an
IMPORTED target, or an ALIAS target is missing?
This warning is for project developers. Use -Wno-dev to suppress it.
[...]
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">[ <span style="color: #666666">87%</span>] Building CXX object appmenu<span style="color: #666666">/</span>CMakeFiles<span style="color: #666666">/</span>kded_appmenu.dir<span style="color: #666666">/</span>appmenu.cpp.o
cd appmenu <span style="color: #666666">&&</span> <span style="color: #666666">/</span>usr<span style="color: #666666">/</span>bin<span style="color: #666666">/</span>c<span style="color: #666666">++</span> <span style="color: #666666">-</span>DKCOREADDONS_LIB <span style="color: #666666">-</span>DKGUIADDONS_LIB <span style="color: #666666">-</span>DQT_CORE_LIB <span style="color: #666666">-</span>DQT_DBUS_LIB <span style="color: #666666">-</span>DQT_DISABLE_DEPRECATED_BEFORE<span style="color: #666666">=0</span> <span style="color: #666666">-</span>DQT_GUI_LIB <span style="color: #666666">-</span>DQT_NETWORK_LIB <span style="color: #666666">-</span>DQT_NO_DEBUG <span style="color: #666666">-</span>DQT_PRINTSUPPORT_LIB <span style="color: #666666">-</span>DQT_WIDGETS_LIB <span style="color: #666666">-</span>DQT_X11EXTRAS_LIB <span style="color: #666666">-</span>DQT_XML_LIB <span style="color: #666666">-</span>D_GNU_SOURCE <span style="color: #666666">-</span>D_LARGEFILE64_SOURCE <span style="color: #666666">-</span>Dkded_appmenu_EXPORTS <span style="color: #666666">-</span>g <span style="color: #666666">-</span>O2 <span style="color: #666666">-</span>fstack<span style="color: #666666">-</span>protector<span style="color: #666666">-</span>strong <span style="color: #666666">-</span>Wformat <span style="color: #666666">-</span>Werror<span style="color: #666666">=</span>format<span style="color: #666666">-</span>security <span style="color: #666666">-</span>D_FORTIFY_SOURCE<span style="color: #666666">=2</span> <span style="color: #666666">-</span>D_FORTIFY_SOURCE<span style="color: #666666">=2</span> <span style="color: #666666">-</span>std<span style="color: #666666">=</span>c<span style="color: #666666">++0</span>x <span style="color: #666666">-</span>fno<span style="color: #666666">-</span>exceptions <span style="color: #666666">-</span>Wall <span style="color: #666666">-</span>Wextra <span style="color: #666666">-</span>Wcast<span style="color: #666666">-</span>align <span style="color: #666666">-</span>Wchar<span style="color: #666666">-</span>subscripts <span style="color: #666666">-</span>Wformat<span style="color: #666666">-</span>security <span style="color: #666666">-</span>Wno<span style="color: #666666">-</span><span style="color: #B00040">long</span><span style="color: #666666">-</span><span style="color: #B00040">long</span> <span style="color: #666666">-</span>Wpointer<span style="color: #666666">-</span>arith <span style="color: #666666">-</span>Wundef <span style="color: #666666">-</span>Wnon<span style="color: #666666">-</span>virtual<span style="color: #666666">-</span>dtor <span style="color: #666666">-</span>Woverloaded<span style="color: #666666">-</span>virtual <span style="color: #666666">-</span>Werror<span style="color: #666666">=</span><span style="color: #008000; font-weight: bold">return</span><span style="color: #666666">-</span>type <span style="color: #666666">-</span>fPIC <span style="color: #666666">-</span>fvisibility<span style="color: #666666">=</span>hidden <span style="color: #666666">-</span>fvisibility<span style="color: #666666">-</span>inlines<span style="color: #666666">-</span>hidden <span style="color: #666666">-</span>I. <span style="color: #666666">-</span>I..<span style="color: #666666">/</span>..<span style="color: #666666">/</span>appmenu <span style="color: #666666">-</span>I.. <span style="color: #666666">-</span>isystem <span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>dbusmenu<span style="color: #666666">-</span>qt5 <span style="color: #666666">-</span>isystem <span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>x86_64<span style="color: #666666">-</span>linux<span style="color: #666666">-</span>gnu<span style="color: #666666">/</span>qt5 <span style="color: #666666">-</span>isystem <span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>x86_64<span style="color: #666666">-</span>linux<span style="color: #666666">-</span>gnu<span style="color: #666666">/</span>qt5<span style="color: #666666">/</span>QtDBus <span style="color: #666666">-</span>isystem <span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>x86_64<span style="color: #666666">-</span>linux<span style="color: #666666">-</span>gnu<span style="color: #666666">/</span>qt5<span style="color: #666666">/</span>QtCore <span style="color: #666666">-</span>isystem <span style="color: #666666">/</span>usr<span style="color: #666666">/</span>lib<span style="color: #666666">/</span>x86_64<span style="color: #666666">-</span>linux<span style="color: #666666">-</span>gnu<span style="color: #666666">/</span>qt5<span style="color: #666666">/</span>mkspecs<span style="color: #666666">/</span>linux<span style="color: #666666">-</span>g<span style="color: #666666">++-64</span> <span style="color: #666666">-</span>isystem <span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>x86_64<span style="color: #666666">-</span>linux<span style="color: #666666">-</span>gnu<span style="color: #666666">/</span>qt5<span style="color: #666666">/</span>QtX11Extras <span style="color: #666666">-</span>isystem <span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>x86_64<span style="color: #666666">-</span>linux<span style="color: #666666">-</span>gnu<span style="color: #666666">/</span>qt5<span style="color: #666666">/</span>QtGui <span style="color: #666666">-</span>isystem <span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>KF5<span style="color: #666666">/</span>KIOCore <span style="color: #666666">-</span>isystem <span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>KF5 <span style="color: #666666">-</span>isystem <span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>KF5<span style="color: #666666">/</span>KCoreAddons <span style="color: #666666">-</span>isystem <span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>KF5<span style="color: #666666">/</span>KService <span style="color: #666666">-</span>isystem <span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>KF5<span style="color: #666666">/</span>KConfigCore <span style="color: #666666">-</span>isystem <span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>KF5<span style="color: #666666">/</span>KIOWidgets <span style="color: #666666">-</span>isystem <span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>KF5<span style="color: #666666">/</span>KJobWidgets <span style="color: #666666">-</span>isystem <span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>x86_64<span style="color: #666666">-</span>linux<span style="color: #666666">-</span>gnu<span style="color: #666666">/</span>qt5<span style="color: #666666">/</span>QtWidgets <span style="color: #666666">-</span>isystem <span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>x86_64<span style="color: #666666">-</span>linux<span style="color: #666666">-</span>gnu<span style="color: #666666">/</span>qt5<span style="color: #666666">/</span>QtNetwork <span style="color: #666666">-</span>isystem <span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>KF5<span style="color: #666666">/</span>KCompletion <span style="color: #666666">-</span>isystem <span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>KF5<span style="color: #666666">/</span>KWidgetsAddons <span style="color: #666666">-</span>isystem <span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>KF5<span style="color: #666666">/</span>KWindowSystem <span style="color: #666666">-</span>isystem <span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>KF5<span style="color: #666666">/</span>KDELibs4Support <span style="color: #666666">-</span>isystem <span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>KF5<span style="color: #666666">/</span>KDELibs4Support<span style="color: #666666">/</span>KDE <span style="color: #666666">-</span>isystem <span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>x86_64<span style="color: #666666">-</span>linux<span style="color: #666666">-</span>gnu<span style="color: #666666">/</span>qt5<span style="color: #666666">/</span>QtPrintSupport <span style="color: #666666">-</span>isystem <span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>KF5<span style="color: #666666">/</span>KCrash <span style="color: #666666">-</span>isystem <span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>KF5<span style="color: #666666">/</span>KConfigWidgets <span style="color: #666666">-</span>I<span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>KF5<span style="color: #666666">/</span>KCodecs <span style="color: #666666">-</span>I<span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>KF5<span style="color: #666666">/</span>KConfigGui <span style="color: #666666">-</span>I<span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>x86_64<span style="color: #666666">-</span>linux<span style="color: #666666">-</span>gnu<span style="color: #666666">/</span>qt5<span style="color: #666666">/</span>QtXml <span style="color: #666666">-</span>I<span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>KF5<span style="color: #666666">/</span>KAuth <span style="color: #666666">-</span>isystem <span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>KF5<span style="color: #666666">/</span>KIOFileWidgets <span style="color: #666666">-</span>I<span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>KF5<span style="color: #666666">/</span>KBookmarks <span style="color: #666666">-</span>I<span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>KF5<span style="color: #666666">/</span>KItemViews <span style="color: #666666">-</span>I<span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>KF5<span style="color: #666666">/</span>KXmlGui <span style="color: #666666">-</span>I<span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>KF5<span style="color: #666666">/</span>Solid <span style="color: #666666">-</span>isystem <span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>KF5<span style="color: #666666">/</span>KI18n <span style="color: #666666">-</span>isystem <span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>KF5<span style="color: #666666">/</span>KNotifications <span style="color: #666666">-</span>isystem <span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>KF5<span style="color: #666666">/</span>KIconThemes <span style="color: #666666">-</span>isystem <span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>KF5<span style="color: #666666">/</span>KGuiAddons <span style="color: #666666">-</span>isystem <span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>KF5<span style="color: #666666">/</span>KUnitConversion <span style="color: #666666">-</span>isystem <span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>KF5<span style="color: #666666">/</span>KTextWidgets <span style="color: #666666">-</span>I<span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>KF5<span style="color: #666666">/</span>SonnetUi <span style="color: #666666">-</span>isystem <span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>KF5<span style="color: #666666">/</span>KParts <span style="color: #666666">-</span>o CMakeFiles<span style="color: #666666">/</span>kded_appmenu.dir<span style="color: #666666">/</span>appmenu.cpp.o <span style="color: #666666">-</span>c ..<span style="color: #666666">/</span>..<span style="color: #666666">/</span>appmenu<span style="color: #666666">/</span>appmenu.cpp
In file included from ..<span style="color: #666666">/</span>..<span style="color: #666666">/</span>appmenu<span style="color: #666666">/</span>appmenu.<span style="color: #A0A000">cpp</span>:<span style="color: #666666">26:0:</span>
..<span style="color: #666666">/</span>..<span style="color: #666666">/</span>appmenu<span style="color: #666666">/</span>appmenu.<span style="color: #A0A000">h</span>:<span style="color: #666666">29:24:</span> fatal <span style="color: #A0A000">error</span>: kdedmodule.<span style="color: #A0A000">h</span>: No such file or directory
<span style="color: #BC7A00">#include <kdedmodule.h></span>
<span style="color: #666666">^</span>
compilation terminated.
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See http://buildd.tanglu.org/data/plasma-workspace_4:5.3.0-0tanglu1/build_amd64/198640/plasma-workspace_5.3.0-0tanglu1_amd64.146006.log</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">plasma-workspace compiles and works fine.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(5180bac)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123664/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>