<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123473/">https://git.reviewboard.kde.org/r/123473/</a>
     </td>
    </tr>
   </table>
   <br />





<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On April 23rd, 2015, 10:59 p.m. UTC, <b>Luigi Toscano</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Apart from more technical issues, the patch includes changes to:
applets/icontasks/metadata.desktop 
containments/folder/metadata.desktop 
kcms/access/kcmaccess.desktop 
kcms/baloo/kcm_baloofile.desktop 

which I think are unrelated.</pre>
 </blockquote>







</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">yes, that just comes from a git dif master</p></pre>
<br />










<p>- Marco</p>


<br />
<p>On April 23rd, 2015, 2:08 p.m. UTC, Marco Martin wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>


<p style="color: grey;"><i>Updated April 23, 2015, 2:08 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is more an experiment on how much modules can be closely ported (and in how much time).
the mouse theme kcm should be pretty much feature complete.
the main problem is the size combobox missing the cursor image due to the QtQuickControls ComboBox being very limited and without a customizable delegate.
all the other functions such as add/remove/ghns seems to work well</p></pre>
  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/icontasks/metadata.desktop <span style="color: grey">(f0b237c)</span></li>

 <li>containments/folder/metadata.desktop <span style="color: grey">(a6d08a7)</span></li>

 <li>kcms/access/kcmaccess.desktop <span style="color: grey">(825b6d7)</span></li>

 <li>kcms/baloo/kcm_baloofile.desktop <span style="color: grey">(2eee6fc)</span></li>

 <li>kcms/cursortheme/CMakeLists.txt <span style="color: grey">(83f3ba2)</span></li>

 <li>kcms/cursortheme/Messages.sh <span style="color: grey">(79450c7)</span></li>

 <li>kcms/cursortheme/cursortheme.desktop <span style="color: grey">(f443208)</span></li>

 <li>kcms/cursortheme/kcm_cursortheme.desktop <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kcms/cursortheme/kcmcursortheme.h <span style="color: grey">(d9e32b2)</span></li>

 <li>kcms/cursortheme/kcmcursortheme.cpp <span style="color: grey">(44576ff)</span></li>

 <li>kcms/cursortheme/package/contents/ui/Delegate.qml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kcms/cursortheme/package/contents/ui/main.qml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kcms/cursortheme/package/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kcms/cursortheme/xcursor/itemdelegate.h <span style="color: grey">(9acb0e9)</span></li>

 <li>kcms/cursortheme/xcursor/itemdelegate.cpp <span style="color: grey">(e737005)</span></li>

 <li>kcms/cursortheme/xcursor/previewwidget.h <span style="color: grey">(4a11e2d)</span></li>

 <li>kcms/cursortheme/xcursor/previewwidget.cpp <span style="color: grey">(79d1305)</span></li>

 <li>kcms/cursortheme/xcursor/sortproxymodel.h <span style="color: grey">(95c9646)</span></li>

 <li>kcms/cursortheme/xcursor/sortproxymodel.cpp <span style="color: grey">(b9d6309)</span></li>

 <li>kcms/cursortheme/xcursor/thememodel.h <span style="color: grey">(bcf046a)</span></li>

 <li>kcms/cursortheme/xcursor/thememodel.cpp <span style="color: grey">(4e4647f)</span></li>

 <li>kcms/cursortheme/xcursor/themepage.h <span style="color: grey">(98c69fd)</span></li>

 <li>kcms/cursortheme/xcursor/themepage.cpp <span style="color: grey">(687bd65)</span></li>

 <li>kcms/cursortheme/xcursor/themepage.ui <span style="color: grey">(6efe60b)</span></li>

 <li>kcms/desktoppaths/desktoppath.desktop <span style="color: grey">(eb2fad5)</span></li>

 <li>kcms/lookandfeel/autotests/lookandfeel/metadata.desktop <span style="color: grey">(3360a85)</span></li>

 <li>kcms/lookandfeel/kcm_lookandfeel.desktop <span style="color: grey">(8550e5c)</span></li>

 <li>kcms/lookandfeel/package/metadata.desktop <span style="color: grey">(6595d6e)</span></li>

 <li>kcms/touchpad/src/applet/qml/metadata.desktop <span style="color: grey">(e9a0bc1)</span></li>

 <li>kcms/touchpad/src/kcm/kcm_touchpad.desktop <span style="color: grey">(c537e5f)</span></li>

 <li>kcms/touchpad/src/kded/kcm_touchpad.notifyrc <span style="color: grey">(9e51e0e)</span></li>

 <li>kcms/touchpad/src/kded/kded_touchpad.desktop <span style="color: grey">(ec076a9)</span></li>

 <li>kcms/useraccount/kcm_useraccount.desktop <span style="color: grey">(46ef110)</span></li>

 <li>layout-templates/org.kde.plasma.desktop.defaultPanel/metadata.desktop <span style="color: grey">(89d7fc3)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123473/diff/" style="margin-left: 3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>


 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/72f14417-e14c-4385-9e8e-959dd1f2d8e4__cursorskcm.png">cursorskcm.png</a></li>

</ul>




  </td>
 </tr>
</table>







  </div>
 </body>
</html>