<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123473/">https://git.reviewboard.kde.org/r/123473/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 23rd, 2015, 9:56 a.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/123473/diff/1/?file=362590#file362590line32" style="color: black; font-weight: bold; text-decoration: underline;">kcms/cursortheme/package/contents/ui/Delegate.qml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">32</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nx">Rectangle</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This isn't a suitable long term substitute for the QStyle highlights.
run Oxygen and it will look wrong.</pre>
</blockquote>
<p>On April 23rd, 2015, 10 a.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">what would you propose for this?
we would need to either make a new element that paints with qstyle or getting that in qtcontrols (which i guess are a frozen since are being replaced?)</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">QQC would be best as ideally this all needs to come via the theming API...but it's too late for Qt5.5.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">A new element in kdeclarative that paints the style would definitely be an option; code wise it wouldn't be very difficult.
some sort of kquickcontrols.DelegateBase</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">To make it clear I don't think we need to block merging on this, kwin KCMs and a few other places already do it "wrong". I just wanted to start the discussion of making things better.</p></pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 23rd, 2015, 9:56 a.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have a cmake issue since you moved some stuff.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">-- The following OPTIONAL packages have not been found:
* USB , User level access to USB devices , <a href="http://libusb.sourceforge.net" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">http://libusb.sourceforge.net</a>
Provides Logitech mouse support in KControl.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
LIBUSB_INCLUDE_DIR (ADVANCED)
used as include directory in directory /home/david/projects/kde5/src/kde/workspace/plasma-desktop/kcms/cursortheme</p></pre>
</blockquote>
<p>On April 23rd, 2015, 10 a.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">does this happens in master for you?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">yes, but not 5.3 branch</p></pre>
<br />
<p>- David</p>
<br />
<p>On April 23rd, 2015, 8:39 a.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated April 23, 2015, 8:39 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is more an experiment on how much modules can be closely ported (and in how much time).
the mouse theme kcm should be pretty much feature complete.
the main problem is the size combobox missing the cursor image due to the QtQuickControls ComboBox being very limited and without a customizable delegate.
all the other functions such as add/remove/ghns seems to work well</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcms/cursortheme/CMakeLists.txt <span style="color: grey">(13ed816)</span></li>
<li>kcms/cursortheme/cursortheme.desktop <span style="color: grey">(f443208)</span></li>
<li>kcms/cursortheme/kcm_cursortheme.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>kcms/cursortheme/kcmcursortheme.h <span style="color: grey">(d9e32b2)</span></li>
<li>kcms/cursortheme/kcmcursortheme.cpp <span style="color: grey">(44576ff)</span></li>
<li>kcms/cursortheme/package/contents/ui/Delegate.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>kcms/cursortheme/package/contents/ui/main.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>kcms/cursortheme/package/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>kcms/cursortheme/xcursor/itemdelegate.h <span style="color: grey">(9acb0e9)</span></li>
<li>kcms/cursortheme/xcursor/itemdelegate.cpp <span style="color: grey">(e737005)</span></li>
<li>kcms/cursortheme/xcursor/previewwidget.h <span style="color: grey">(4a11e2d)</span></li>
<li>kcms/cursortheme/xcursor/previewwidget.cpp <span style="color: grey">(79d1305)</span></li>
<li>kcms/cursortheme/xcursor/sortproxymodel.h <span style="color: grey">(95c9646)</span></li>
<li>kcms/cursortheme/xcursor/sortproxymodel.cpp <span style="color: grey">(b9d6309)</span></li>
<li>kcms/cursortheme/xcursor/thememodel.h <span style="color: grey">(bcf046a)</span></li>
<li>kcms/cursortheme/xcursor/thememodel.cpp <span style="color: grey">(4e4647f)</span></li>
<li>kcms/cursortheme/xcursor/themepage.h <span style="color: grey">(98c69fd)</span></li>
<li>kcms/cursortheme/xcursor/themepage.cpp <span style="color: grey">(687bd65)</span></li>
<li>kcms/cursortheme/xcursor/themepage.ui <span style="color: grey">(6efe60b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123473/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/72f14417-e14c-4385-9e8e-959dd1f2d8e4__cursorskcm.png">cursorskcm.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>