<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123351/">https://git.reviewboard.kde.org/r/123351/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 15th, 2015, 10:53 p.m. CEST, <b>David Kahles</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I just noticed another issue: when pressing the shutdown/reboot button, the login bar is shifted to the left and the shutdown/reboot bar comes in from the right. If you have a monitor left of the primary monitor, the loginbar is shifted to this monitor before it disappears. I suppose, if you have a monitor right to the primary monitor, the shutdown/reboot bar would first appear on the right monitor before it gets's shifted to the primary one.
A solution would be, to disable the animation of we have more than 1 monitor, or to "fade" (don't know the right term, i'm talking of increasing the visibility slowly) the shutdown/login bar in.
I don't know how the animation stuff works and don't have much time atm, so this might not go into 5.3 in time..</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Do you have any better ideas or hints?</p></pre>
<br />
<p>- David</p>
<br />
<p>On April 15th, 2015, 10:57 p.m. CEST, David Kahles wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and David Edmundson.</div>
<div>By David Kahles.</div>
<p style="color: grey;"><i>Updated April 15, 2015, 10:57 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">With the last comment, the login promt was displayed on every screen to
fix a multiscreen issue. But this introduces a bug when two monitors
are attached and the screens are configured to overlap and be mirrored
on both monitors.
This can happen when xorg is autoconfigured (kscreen isn't loaded in
sddm). In this case, two loginbars are created (because there are two
screens) but are both displayed on both monitors (because the
screens are overlapping).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">With this change, there is only one loginbar on the primary monitor,
so this will not be a problem anymore. This is also the behavior of
other sddm themes, as well as GDM and Windows.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">SDDM-BUG: #265 (https://github.com/sddm/sddm/issues/265, it's fixed by the last change to the login promt, but the change introduced this bug)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested with one monitor (xorg autoconfiguration) and two monitors in the following configurations:
- xorg autoconfiguration
- both monitors side by side
- configuration to get a behavior similar to this: https://cloud.githubusercontent.com/assets/48491/7106740/1cf262f2-e14c-11e4-84fa-1bf5dc6a2dfb.jpg (This is the mentioned bug)
This still draws the background multiple times, which could be overlapping depending on the order of the screens, which is ugly but usable. (Only in this configuration)
A fix for this would require to sort out overlapping screens and choose the biggest one in sddm, but this gets complicated if one screens doesn't contain an other one completely,
so I don't know how to fix this.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lookandfeel/contents/loginmanager/Main.qml <span style="color: grey">(6d24e7f842c5f379946102c533fe57272b1e026b)</span></li>
<li>lookandfeel/contents/loginmanager/README.txt <span style="color: grey">(0c5ed9f7fa27a29367ea741abedce3ddac74c549)</span></li>
<li>lookandfeel/contents/loginmanager/dummydata/screenModel.qml <span style="color: grey">(981f364886102d833cac0f12ee173eb725cd45f5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123351/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>