<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122884/">https://git.reviewboard.kde.org/r/122884/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On huhtikuu 10th, 2015, 9:16 ap EEST, <b>Siddhartha Sahu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hey. This commit breaks breeze decoration for me. The titlebar is completely black for all windows and also in the "Windows Decoration" kcm list.
Titlebar buttons customization also does not work.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Reverting this commit fixes the bug.</p></pre>
</blockquote>
<p>On huhtikuu 10th, 2015, 9:17 ap EEST, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I rather doubt that this commit can turn it black. Please ensure that you have an up to date build of kwin, too.</p></pre>
</blockquote>
<p>On huhtikuu 10th, 2015, 9:27 ap EEST, <b>Siddhartha Sahu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi Martin,</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have plasma 5 built from git using kdesrc-build (updated almost everyday).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Just to make sure, I compiled and installed breeze master again. KCM shows black. Revert commit, install, KCM shows everything ok.</p></pre>
</blockquote>
<p>On huhtikuu 10th, 2015, 9:28 ap EEST, <b>Siddhartha Sahu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Kwin info: https://paste.kde.org/phjgqezjg</p></pre>
</blockquote>
<p>On huhtikuu 10th, 2015, 9:50 ap EEST, <b>Mika Allan Rauhala</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Could you check if ~/.config/kdeglobals has [WM] group? Lack of it might cause DecorationPalette to ignore the color scheme, a good thing with a broken custom color scheme, but not with a default one.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Could you try https://git.reviewboard.kde.org/r/123320/?</p></pre>
<br />
<p>- Mika Allan</p>
<br />
<p>On huhtikuu 1st, 2015, 6:25 ip EEST, Mika Allan Rauhala wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Mika Allan Rauhala.</div>
<p style="color: grey;"><i>Updated huhti 1, 2015, 6:25 ip</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
breeze
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Breeze::ColorSettings now uses KDecoration2::DecoratedClient::color() for getting additional colors instead of reading them from kdeglobals. This allows per window color schemes with custom titlebar colors to work.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecoration/breezecolorsettings.h <span style="color: grey">(40e04fb871f552bf31112d02cad86d286aa416c0)</span></li>
<li>kdecoration/breezecolorsettings.cpp <span style="color: grey">(c52bfbe624fc79842f504a586cee20724b176be4)</span></li>
<li>kdecoration/breezedecoration.cpp <span style="color: grey">(175a13d0b0a863e1db99a57b6d82fa254249bb77)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122884/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>