<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123271/">https://git.reviewboard.kde.org/r/123271/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 7th, 2015, 12:59 p.m. UTC, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So if the panel is horizontal, and high, people get a huge icon. If it's vertical and wide, the icon is limited and centered? That's pretty inconsistent.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I agree that a huge button may not be what the user wants, but then what's huge? Your patch seems to work incidentally, since you have a typo in the code which essentially invalidates the preferred size.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'd like to see a better thought-through solution for this, as such, I don't find this patch acceptable.</p></pre>
</blockquote>
<p>On April 7th, 2015, 1:03 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">also, it shouldn't have a behavior inconsistent with every other popupapplet icon</p></pre>
</blockquote>
<p>On April 7th, 2015, 9:51 p.m. UTC, <b>Mathias Kraus</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The size is also limited in the horizontal panel and centered. I don't know if this was also the case in plasma 1, but at least on the vertical panel the size was limited. Like I said in a previous commit, this restores the behaviour from plasma 1 on a vertical panel. I just noticed, that the icons from e.g. the task list and the system tray change with the selected font size. Would this also be an option for the kickoff icon? If yes, how can I access this size?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What do you mean with popupapplet? Keep in mind, I'm not a plasma developer, so it might not be obvious for me.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I mean that most of the appelts will collapse in an icon just like kickoff.
So now kickoff and only kickoff is behaving different in vertical panels, and that would be a bug</p></pre>
<br />
<p>- Marco</p>
<br />
<p>On April 7th, 2015, 9:56 p.m. UTC, Mathias Kraus wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Mathias Kraus.</div>
<p style="color: grey;"><i>Updated April 7, 2015, 9:56 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In vertical panels, the kickoff button is huge. This patch limits the size of the kickoff button.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">see screenshots</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/kickoff/package/contents/ui/CompactRepresentation.qml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123271/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/a4848ebd-8dd6-4e46-9f28-ab01fbe13cc6__kickoff-horizontal-before.png">kickoff-horizontal-before</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b6532939-498e-4c3d-85da-07c0a8162b2f__kickoff-horizontal-after.png">kickoff-horizontal-after</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b71c4d86-dff3-4b2f-a11e-430bc59a732d__kickoff-vertical-before.png">kickoff-vertical-before</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/55396e5a-1a2d-4523-87f8-4d9cd1d0f067__kickoff-vertical-after.png">kickoff-vertical-after</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>