<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123280/">https://git.reviewboard.kde.org/r/123280/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't understand the moving the recently used model startup part. </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What's broken about loading it later?</p></pre>
<br />
<p>- David Edmundson</p>
<br />
<p>On April 6th, 2015, 9:35 p.m. UTC, Anthony Vital wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Anthony Vital.</div>
<p style="color: grey;"><i>Updated April 6, 2015, 9:35 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This does two things:
- Instantiate the RecentlyUsedModel at startup, otherwise it's not available
until the History tab is opened and this leads to some mixing in the recent
apps list/the list not being updated until then.
- Move the registration of the service handler to the launcher, so that the
apps launched from the Favorites tab are registered without having to open
the Applications tab first.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Launched applications from Favorites and Applications tab without opening the History tab first, items are added correctly.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/kickoff/core/applicationmodel.cpp <span style="color: grey">(9af58a36d5c3349ad1f2bffd0f7f93eebd99663e)</span></li>
<li>applets/kickoff/core/urlitemlauncher.cpp <span style="color: grey">(58a6c20cec60ede54ea55d927064eaf8af9b4f46)</span></li>
<li>applets/kickoff/package/contents/ui/FullRepresentation.qml <span style="color: grey">(15dde962f2321d9b186c9d73246491dc48b398bb)</span></li>
<li>applets/kickoff/package/contents/ui/RecentlyUsedView.qml <span style="color: grey">(df25db21db4a6bd764dee3ff8583e2bdc35fe341)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123280/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>