<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123251/">https://git.reviewboard.kde.org/r/123251/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 4th, 2015, 3:44 p.m. UTC, <b>Eike Hein</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This won't catch launches from the favorites sidebar or the Recent Applications model. You either have to add more hooks there, or you could actually hook into RecentApplications::addApp for now, which is what all the other models' appLaunched() signals are connected to. When I port Recent Applications to KAMD after 5.3, I'll refactor and addApp() turns into something that solely does that KActivities call.</p></pre>
</blockquote>
<p>On April 4th, 2015, 3:50 p.m. UTC, <b>Ivan Čukić</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hmh, this was kinda intentional - though, again something that is not necessarily a good idea.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Namly, if something is in the favs, there is no reason to show it in the recent ones as well - it will be just redundant.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">On the other hand, not adding something to the statistics, spoils the statistics.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'll take whichever approach you think is more fitting.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Well, right now Recent Apps doesn't use KAMD and the favorites get added there anyway, so it's already behaving this way right now :). I think it makes sense for consistency purposes and the stats factor personally. I mean you can take this argument quite far - e.g. by the above logic, panel launchers shouldn't be recorded either because then you have Recent Apps entries that are redundant with the panel. Heck, you can even extend it to the menu itself in some sense. I think it's simpler and more predictable not to get into the game of figuring out what the user might consider redundant, and just catch all launches. Less risky.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Maybe I'll actually get around to porting Recent Apps to KAMD before freeze, shouldn't really take more than an hour (probably less) after all and with this addition it could do everything it does right now (but got to focus on finishing the other, fancier bits for now).</p></pre>
<br />
<p>- Eike</p>
<br />
<p>On April 4th, 2015, 8:56 a.m. UTC, Ivan Čukić wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, Eike Hein and Marco Martin.</div>
<div>By Ivan Čukić.</div>
<p style="color: grey;"><i>Updated April 4, 2015, 8:56 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The collected data can be used to show the recently started applications.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The uri is applications:menuId, as specified by applications KIO.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/kicker/CMakeLists.txt <span style="color: grey">(d96c34e)</span></li>
<li>applets/kicker/plugin/appsmodel.cpp <span style="color: grey">(03b666a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123251/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>