<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123164/">https://git.reviewboard.kde.org/r/123164/</a>
     </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+1 from me.
Maybe wait for another +1 from someone else as it's quite a huge patch.</p></pre>
 <br />









<p>- David Edmundson</p>


<br />
<p>On April 2nd, 2015, 10:13 a.m. UTC, David Rosca wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>

<div>Review request for Bluedevil and Plasma.</div>
<div>By David Rosca.</div>


<p style="color: grey;"><i>Updated April 2, 2015, 10:13 a.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
bluedevil
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is a replacement for bluedevil-monolithic.
The code is based on network management plasmoid and it does basically the same but for Bluetooth devices.</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've been running it for some time already and it works fine.</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(94b56fb)</span></li>

 <li>src/CMakeLists.txt <span style="color: grey">(b804f2b)</span></li>

 <li>src/applet/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/applet/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/applet/package/contents/code/logic.js <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/applet/package/contents/ui/BluetoothApplet.qml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/applet/package/contents/ui/CompactRepresentation.qml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/applet/package/contents/ui/DeviceItem.qml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/applet/package/contents/ui/FullRepresentation.qml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/applet/package/contents/ui/Header.qml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/applet/package/contents/ui/SwitchButton.qml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/applet/package/contents/ui/Toolbar.qml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/applet/package/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/applet/plugin/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/applet/plugin/bluetoothplugin.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/applet/plugin/bluetoothplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/applet/plugin/devicesproxymodel.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/applet/plugin/devicesproxymodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/applet/plugin/launchapp.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/applet/plugin/launchapp.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/applet/plugin/notify.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/applet/plugin/notify.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/applet/plugin/qmldir <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/bluedevil.notifyrc <span style="color: grey">(f87dc95)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123164/diff/" style="margin-left: 3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>


 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/acba4387-a4e7-4e77-830d-91dc5ed5c574__snapshot4.png">snapshot4.png</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/d0cab8ca-a62b-4672-9600-cbd61de25c63__snapshot5.png">snapshot5.png</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/03/31/d8ffae3d-f4f4-4bf1-b5ad-27d1298d4d3f__btapplet6.png">btapplet6.png</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/03/31/957074cc-acf4-40b1-bb08-857ac6937669__btapplet7.png">btapplet7.png</a></li>

</ul>




  </td>
 </tr>
</table>







  </div>
 </body>
</html>