<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122842/">https://git.reviewboard.kde.org/r/122842/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Some really minor nit picky things below, feel free to ignore them :)</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/122842/diff/4/?file=356474#file356474line171" style="color: black; font-weight: bold; text-decoration: underline;">applets/notifications/package/contents/ui/Notifications.qml</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">171</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">popupLocation:</span> <span class="nx">plasmoid</span><span class="p">.</span><span class="nx">location</span> <span class="o">===</span> <span class="nx">PlasmaCore</span><span class="p">.</span><span class="nx">Types</span><span class="p">.</span><span class="nx">TopEdge</span> <span class="o">?</span> <span class="k"><span class="hl">Qt</span>.Top<span class="hl">Edge</span> :</span> <span class="nx"><span class="hl">Qt</span></span><span class="p">.</span><span class="nx">Bottom<span class="hl">Edge</span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">171</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">popupLocation:</span> <span class="nx"><span class="hl">plasmoid</span></span><span class="p"><span class="hl">.</span></span><span class="nx"><span class="hl">nativeInterface</span></span><span class="p"><span class="hl">.</span></span><span class="nx"><span class="hl">screenPosition</span></span><span class="hl"> </span><span class="o"><span class="hl">==</span></span><span class="hl"> </span><span class="mi"><span class="hl">0</span></span><span class="hl"> </span><span class="o"><span class="hl">?</span></span><span class="hl"> </span><span class="p"><span class="hl">(</span></span><span class="nx">plasmoid</span><span class="p">.</span><span class="nx">location</span> <span class="o">===</span> <span class="nx">PlasmaCore</span><span class="p">.</span><span class="nx">Types</span><span class="p">.</span><span class="nx">TopEdge</span> <span class="o">?</span> <span class="k"><span class="hl">NotificationsHelper</span>.Top<span class="hl">Right</span> :</span> <span class="nx"><span class="hl">NotificationsHelper</span></span><span class="p">.</span><span class="nx">Bottom<span class="hl">Right</span></span><span class="p"><span class="hl">)</span></span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I would turn that into a proper if statement, a complex ternary operator is quite confusing</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/122842/diff/4/?file=356476#file356476line34" style="color: black; font-weight: bold; text-decoration: underline;">applets/notifications/package/contents/ui/configNotifications.qml</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">34</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nx">signal</span> <span class="nx">configurationChanged</span><span class="p">()</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You don't need the ()</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/122842/diff/4/?file=356478#file356478line35" style="color: black; font-weight: bold; text-decoration: underline;">applets/notifications/plugin/notificationshelper.h</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class QTimer;</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">35</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Q_PROPERTY</span><span class="p">(</span><span class="n"><span class="hl">Qt</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">Edge</span></span> <span class="n">popupLocation</span> <span class="n">MEMBER</span> <span class="n">m_popupLocation</span> <span class="n">WRITE</span> <span class="n">setPopupLocation</span> <span class="n">NOTIFY</span> <span class="n">popupLocationChanged</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">35</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Q_PROPERTY</span><span class="p">(</span><span class="n"><span class="hl">PositionOnScreen</span></span> <span class="n">popupLocation</span> <span class="n">MEMBER</span> <span class="n">m_popupLocation</span> <span class="n">WRITE</span> <span class="n">setPopupLocation</span> <span class="n">NOTIFY</span> <span class="n">popupLocationChanged</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If you already have WRITE and NOTIFY, just add a READ too</p></pre>
</div>
</div>
<br />
<p>- Kai Uwe Broulik</p>
<br />
<p>On März 24th, 2015, 12:19 nachm. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated März 24, 2015, 12:19 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=344841">344841</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Allows to select each corner and top or bottom edges of the screen.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The radio selection thing is currently a bit ugly and I'd like to ask for suggestions on it (I originally wanted to add VDG here but there's no vdg group (?) so I'll post in the forums).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">All positions work</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/notifications/CMakeLists.txt <span style="color: grey">(113d731)</span></li>
<li>applets/notifications/lib/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/notifications/lib/notificationsapplet.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/notifications/lib/notificationsapplet.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/notifications/package/contents/ui/Notifications.qml <span style="color: grey">(4312774)</span></li>
<li>applets/notifications/package/contents/ui/ScreenPositionSelector.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/notifications/package/contents/ui/configNotifications.qml <span style="color: grey">(cda9ac9)</span></li>
<li>applets/notifications/package/metadata.desktop <span style="color: grey">(333fa2c)</span></li>
<li>applets/notifications/plugin/notificationshelper.h <span style="color: grey">(ca0b63b)</span></li>
<li>applets/notifications/plugin/notificationshelper.cpp <span style="color: grey">(cd8a5a5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122842/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/03/06/f80f9345-3d5f-49b4-83d7-16ecbfbc607a__notification_pos.png">Screenshot</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/03/11/e1fd3405-b008-4d6e-90c7-2000ab011008__notifications_config.png">New Screenshot</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>