<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122842/">https://git.reviewboard.kde.org/r/122842/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thank you for adding usability!</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If the checkbox is disabled, the whole visualization of the screen should be greyed out / desaturated, because it is simply not relevant in that case.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">From the design perspective it would make sense to completely harmonize the representation of the screen with the screen edge KCM (except for round vs. square buttons). I'll let our visual designers decide whether the background should be light or dark, as long as it's the same in both cases.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Otherwise, it's fine. Very nice feature!</p></pre>
<br />
<p>- Thomas Pfeiffer</p>
<br />
<p>On April 1st, 2015, 5:30 p.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and KDE Usability.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated April 1, 2015, 5:30 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=344841">344841</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Allows to select each corner and top or bottom edges of the screen.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The radio selection thing is currently a bit ugly and I'd like to ask for suggestions on it (I originally wanted to add VDG here but there's no vdg group (?) so I'll post in the forums).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">All positions work</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/notifications/CMakeLists.txt <span style="color: grey">(113d731)</span></li>
<li>applets/notifications/lib/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/notifications/lib/notificationsapplet.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/notifications/lib/notificationsapplet.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/notifications/package/contents/ui/Notifications.qml <span style="color: grey">(4312774)</span></li>
<li>applets/notifications/package/contents/ui/ScreenPositionSelector.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/notifications/package/contents/ui/configNotifications.qml <span style="color: grey">(cda9ac9)</span></li>
<li>applets/notifications/package/metadata.desktop <span style="color: grey">(333fa2c)</span></li>
<li>applets/notifications/plugin/notificationshelper.h <span style="color: grey">(ca0b63b)</span></li>
<li>applets/notifications/plugin/notificationshelper.cpp <span style="color: grey">(cd8a5a5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122842/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/03/06/f80f9345-3d5f-49b4-83d7-16ecbfbc607a__notification_pos.png">Screenshot</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/03/11/e1fd3405-b008-4d6e-90c7-2000ab011008__notifications_config.png">New Screenshot</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>