<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122679/">https://git.reviewboard.kde.org/r/122679/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On März 30th, 2015, 7:12 nachm. UTC, <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Was adding the usability group more meant as a heads-up to inform us that things are happening on this front, or are you expecting an actual usability review?
In the latter case, we'd need some kind of visualization or at least detailed description of what is happening on the UI side, since we can't read code all that well ;)</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The main (only) question for the usability team right now is "what do we do with panels":
Should the hide or show when showing the desktop (having in mind this to be a dashboard "replacement")</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Related question: what about windows that are marked to keep above?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hybrids (w/ eg. Kais and kdeuser56's comments in mind) are possible as well, ie. we could only show "special" docks/panels/windows (which however need to indicate relation by marking themselves transient for the desktop or "keepabove" - techincal detail, though ;-)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also see my very first comment on this.</p>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Aside this, you may want to comment on the effects, but they're scripts and can easily be adjusted and tried w/o compilation once the usability / visual design folks have the beta installed or so.</p></pre>
<br />
<p>- Thomas</p>
<br />
<p>On März 30th, 2015, 9:06 nachm. UTC, Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, and Marco Martin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated März 30, 2015, 9:06 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=344083">344083</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">commit b4e3a736c3643179b5b4ea73f7706918a03483fe
Author: Thomas Lübking
Date: Mon Mar 30 11:38:54 2015 +0200</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">add eyeOnScreen effect
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">commit 4aaeeda8fbebded0e915b39a54092c586de179ce
Author: Thomas Lübking
Date: Mon Mar 30 11:38:38 2015 +0200</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">support gaussian curve and animationEnded signal in ScriptedEffect
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">commit a1e7f1a2ccefffd42e360bbaae48ecdfaa5b1ff4 <br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Author: Thomas Lübking <br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Date: Sun Mar 29 00:15:57 2015 +0100 </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">Add effect to move windows to corners on showing the desktop
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">commit d92c46e96fe9fb13403b859c5e334b618d45d268 <br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Author: Thomas Lübking <br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Date: Sun Mar 29 00:15:22 2015 +0100 </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">Remove AnimationData wrapper around metadata. Allow to set metadata directly in animation objects
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">commit ed38cf37b26aa15d77c5b73734581055be234233 <br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Author: Thomas Lübking <br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Date: Sun Mar 29 00:13:41 2015 +0100 </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">make window elevation scriptable
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">commit c297fd5c55ba862151265e4b8b65b5ffe6048a8d <br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Author: Thomas Lübking <br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Date: Sun Mar 29 00:12:21 2015 +0100 </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">forward showingDesktop signal to effects
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">commit 570a92331f3691c1fb2affa4f853c75d6062f7e3 <br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Author: Thomas Lübking <br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Date: Sun Mar 29 00:08:32 2015 +0100 </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">emit signal when showingDesktop changes
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5
Author: Thomas Lübking
Date: Sun Feb 22 16:41:45 2015 +0100</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">add "MinimizeAll" script
to compensate withdrawn core feature (which
though has been hidden so far)
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">commit 983efb916e282d2263b4abcc92f714c06b3bfcc1
Author: Thomas Lübking
Date: Wed Feb 18 02:09:00 2015 +0100</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">break showingDesktop w/ tabbox/PW/DG
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is now crucial, because while before (the minimized) windows were conditionally shown, but are now always behind the desktop.
Also, it makes the tabbox more consistent.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">commit ff531c8e2adc407da00bef88f18d03e3829b25fa
Author: Thomas Lübking
Date: Wed Feb 18 01:37:45 2015 +0100</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">implement showingDesktop by raising the desktop window
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">commit 190a0cc022d9935d658a6218d0b3caa79b038563
Author: Thomas Lübking
Date: Wed Feb 18 00:09:46 2015 +0100</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">remove secret showDesktopIsMinimizeAll feature
</pre></div>
</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">The script (though mostly in KWin4, trouble w/ ksycoca5...)</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Obviously the supersecret key is now dead ;-)</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Been playing around with alternate desktop showing.</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>client.h <span style="color: grey">(6b947fe)</span></li>
<li>client.cpp <span style="color: grey">(b6af2fa)</span></li>
<li>effects.h <span style="color: grey">(ae71d61)</span></li>
<li>effects.cpp <span style="color: grey">(20a8773)</span></li>
<li>effects/CMakeLists.txt <span style="color: grey">(98a9349)</span></li>
<li>effects/badbadwindows/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>effects/badbadwindows/package/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>effects/badbadwindows/package/contents/code/main.js <span style="color: grey">(PRE-CREATION)</span></li>
<li>effects/badbadwindows/package/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>effects/desktopgrid/desktopgrid.cpp <span style="color: grey">(97cb2a3)</span></li>
<li>effects/eyeonscreen/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>effects/eyeonscreen/package/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>effects/eyeonscreen/package/contents/code/main.js <span style="color: grey">(PRE-CREATION)</span></li>
<li>effects/eyeonscreen/package/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>effects/presentwindows/presentwindows.cpp <span style="color: grey">(7a62ec0)</span></li>
<li>kwin.kcfg <span style="color: grey">(80ca365)</span></li>
<li>layers.cpp <span style="color: grey">(ae08207)</span></li>
<li>libkwineffects/kwineffects.h <span style="color: grey">(b77e461)</span></li>
<li>manage.cpp <span style="color: grey">(8b1a2ee)</span></li>
<li>options.h <span style="color: grey">(67e5868)</span></li>
<li>options.cpp <span style="color: grey">(cdaa851)</span></li>
<li>scripting/scriptedeffect.h <span style="color: grey">(39af241)</span></li>
<li>scripting/scriptedeffect.cpp <span style="color: grey">(ba646f6)</span></li>
<li>scripts/CMakeLists.txt <span style="color: grey">(34dedb7)</span></li>
<li>scripts/minimizeall/contents/code/main.js <span style="color: grey">(PRE-CREATION)</span></li>
<li>scripts/minimizeall/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>tabbox/tabbox.cpp <span style="color: grey">(4a00e4b)</span></li>
<li>workspace.h <span style="color: grey">(16fa351)</span></li>
<li>workspace.cpp <span style="color: grey">(f9c1ab1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122679/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>