<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123173/">https://git.reviewboard.kde.org/r/123173/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks like the notification is working if the plasmoid is added somewhere but not from within plasmawindowed.. any ideas?</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Because the notifications dataengine is registering itself as org.freedesktop.Notifications service, and only one process can do that in one dbus-session. When you start plasmawindowed, it would fail because there already is a service registered from your main plasmashell. plasmoidviewer should work fine.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also, I think if you send the notification from this dataengine, user will not have an option to configure this notification (with KNotifyConfig).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That being said, I don't know of any better solution than use C++ plugin. Maybe we should create an import for KNotifications.</p></pre>
<br />
<p>- David Rosca</p>
<br />
<p>On March 29th, 2015, 2:20 p.m. UTC, Bernhard Friedreich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Bernhard Friedreich.</div>
<p style="color: grey;"><i>Updated March 29, 2015, 2:20 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Commit 1: Fixed codingstyle
Commit 2: Fixed warning "Unable to assign int to QEasingCurve"
Commit 3: Added notification on timer completion (not working yet)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Event is fired when the timer is finished (console.log output works) but the notification won't show up.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I get this message on console: Are we the only client? (Both have to be true) false true</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">How can I send a notification from qml (without c++)? Am I on the right track?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[Edit] Looks like the notification is working if the plasmoid is added somewhere but not from within plasmawindowed.. any ideas?</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/timer/package/contents/ui/TimerDigit.qml <span style="color: grey">(94ec17d2c1e6fb02f6d8d3b1c0ea75f16b0fa405)</span></li>
<li>applets/timer/package/contents/ui/timer.qml <span style="color: grey">(09df67004f07352436a30195fb13c2550f8ebce7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123173/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>