<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123164/">https://git.reviewboard.kde.org/r/123164/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 29th, 2015, 12:13 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/123164/diff/1/?file=357009#file357009line1" style="color: black; font-weight: bold; text-decoration: underline;">src/applet/package/contents/ui/SwitchButton.qml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm">/*</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">is this a direct copy from nm-qt?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Maybe we could put it in plasmaextras?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No, it is not. There is a little hack with height being the height of checkbox (and not icon as in plasma-nm) because I am not using a svg icon and PlasmaCore.IconItem seems to be adding too big margins.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also, there is a small change in behavior that it is possible to click on disabled checkbox. This does not seem to be needed in plasma-nm because there is an airplane mode button, but it is needed here.</p></pre>
<br />
<p>- David</p>
<br />
<p>On March 28th, 2015, 7:43 p.m. UTC, David Rosca wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Bluedevil and Plasma.</div>
<div>By David Rosca.</div>
<p style="color: grey;"><i>Updated March 28, 2015, 7:43 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
bluedevil
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is a replacement for bluedevil-monolithic.
The code is based on network management plasmoid and it does basically the same but for Bluetooth devices.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've been running it for some time already and it works fine.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(94b56fb)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(b804f2b)</span></li>
<li>src/applet/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/applet/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/applet/package/contents/code/logic.js <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/applet/package/contents/config/config.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/applet/package/contents/config/main.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/applet/package/contents/ui/BluetoothApplet.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/applet/package/contents/ui/CompactRepresentation.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/applet/package/contents/ui/ConfigGeneral.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/applet/package/contents/ui/DeviceItem.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/applet/package/contents/ui/FullRepresentation.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/applet/package/contents/ui/Header.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/applet/package/contents/ui/SwitchButton.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/applet/package/contents/ui/Toolbar.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/applet/package/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/applet/plugin/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/applet/plugin/bluetoothplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/applet/plugin/bluetoothplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/applet/plugin/devicesproxymodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/applet/plugin/devicesproxymodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/applet/plugin/launchapp.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/applet/plugin/launchapp.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/applet/plugin/notify.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/applet/plugin/notify.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/applet/plugin/qmldir <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/bluedevil.notifyrc <span style="color: grey">(72257ed)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123164/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/acba4387-a4e7-4e77-830d-91dc5ed5c574__snapshot4.png">snapshot4.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/d0cab8ca-a62b-4672-9600-cbd61de25c63__snapshot5.png">snapshot5.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>