<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123088/">https://git.reviewboard.kde.org/r/123088/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 20th, 2015, 9:23 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+1 from here (will read it more)</p></pre>
</blockquote>
<p>On March 20th, 2015, 11:54 p.m. UTC, <b>Eike Hein</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+1 too, takes the risk out of me shipping code against the experimental API in 5.3 and breaking Plasma in a KF upgrade</p></pre>
</blockquote>
<p>On March 21st, 2015, 9:10 a.m. UTC, <b>Ivan Čukić</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Waiting for +2 since +1 +1 = 1.98 on the first Pentium processor. :)</p></pre>
</blockquote>
<p>On March 21st, 2015, 7:41 p.m. UTC, <b>Hrvoje Senjan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">From buildsystem/packager point of view i am wondering is installing cmake files and headers needed here?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If yes, then maybe better place would be plasma-workspace which also installs both, unlinke plasma-desktop.
If no, then it would be great to avoid installing headers, cmake conf & shlibs devel symlink.</p></pre>
</blockquote>
<p>On March 24th, 2015, 1:52 p.m. UTC, <b>Ivan Čukić</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I guess we can live without the headers installed. Though, it would make the library really limited to plasma-desktop.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Marco, Eike thoughts?</p></pre>
</blockquote>
<p>On March 24th, 2015, 8:40 p.m. UTC, <b>Eike Hein</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'd say lose the headers for now - we probably actually don't want someone outside p-d using them because then we run into similar problems as with KF. Let's just use p-d as the vetting for making the API supportable.</p></pre>
</blockquote>
<p>On March 24th, 2015, 9:41 p.m. UTC, <b>Ivan Čukić</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What about ktp?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The usage collection part is in the regular KActivities, so that is not the problem. But showing recent/popular contacts will need KAcivitiesStats.</p></pre>
</blockquote>
<p>On March 24th, 2015, 10:43 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Next KTp release is with KDE Applications 15.08 (I mean the one that can include this), so there should be plenty of time to make it proper?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Should work out then. We can make KTP enter the info right away (using the stable API) and have Kicker query it (using the internal lib), and by August KTP might have stable KAS API to use to query as well.</p></pre>
<br />
<p>- Eike</p>
<br />
<p>On March 20th, 2015, 9:07 p.m. UTC, Ivan Čukić wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, Eike Hein and Marco Martin.</div>
<div>By Ivan Čukić.</div>
<p style="color: grey;"><i>Updated March 20, 2015, 9:07 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The experimental library can not land in the kactivities framework just yet. Since it is to be used by plasma-desktop in the next release, we need to include it (for the time being) in p-d.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The idea came from Eike. While it has downsides, it also has a few benefits:
- no need to have a monthly release cycle, so we can actually do work without much bureaucracy surrounding API and ABI compatibility;
- when the library becomes stable, it will move to KActivities and lose the 'experimental' part of the name. This means that the distributions will not have issues of two packages providing the same files;
- no need to sync the releases and think about which KActivities version plasma 5.x will be used against;
- I guess I'm forgetting more benefits. :)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The patch includes update.sh script that syncs this code with that in KActivities. (the development should still be in the KActivities ivan/libkactivities-experimental-stats branch)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(2d43890)</span></li>
<li>lib/kactivities-stats/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/KF5ActivitiesExperimentalStatsConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/README <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/common/database/Database.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/common/database/Database.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/common/database/schema/ResourcesDatabaseSchema.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/common/database/schema/ResourcesDatabaseSchema.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/common/dbus/common.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Activities.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Activities.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Activities.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Features.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Resources.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.ResourcesLinking.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.ResourcesScoring.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/common/specialvalues.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/lib/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/lib/stats/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/lib/stats/activitiessync_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/lib/stats/activitiessync_p.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/lib/stats/libKActivitiesExperimentalStats.pc.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/lib/stats/query.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/lib/stats/query.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/lib/stats/resultmodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/lib/stats/resultmodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/lib/stats/resultset.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/lib/stats/resultset.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/lib/stats/resultwatcher.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/lib/stats/resultwatcher.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/lib/stats/terms.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/lib/stats/terms.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/lib/stats/version.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/lib/stats/version.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/utils/continue_with.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/utils/d_ptr.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/utils/d_ptr_implementation.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/utils/dbusfuture_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/utils/dbusfuture_p.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/utils/debug_and_return.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/utils/for_each_assoc.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/utils/lazy_val.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/utils/member_matcher.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/utils/merge_into.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/utils/qsqlquery_iterator.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/utils/qsqlquery_iterator.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/utils/range.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/utils/remove_if.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/utils/slide.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/update.sh <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123088/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>