<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122679/">https://git.reviewboard.kde.org/r/122679/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">From my side I would like to see this in 5.3</p></pre>
<br />
<p>- Martin Gräßlin</p>
<br />
<p>On February 26th, 2015, 2:16 p.m. CET, Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kwin, Plasma, KDE Usability, Martin Gräßlin, and Marco Martin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Feb. 26, 2015, 2:16 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=344083">344083</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">commit a1b80b4e310b2c75b4d9811af1d23f699bc658b5
Author: Thomas Lübking
Date: Sun Feb 22 16:41:45 2015 +0100</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">add "MinimizeAll" script
to compensate withdrawn core feature (which
though has been hidden so far)
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">commit 983efb916e282d2263b4abcc92f714c06b3bfcc1
Author: Thomas Lübking
Date: Wed Feb 18 02:09:00 2015 +0100</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">break showingDesktop w/ tabbox/PW/DG
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is now crucial, because while before (the minimized) windows were conditionally shown, but are now always behind the desktop.
Also, it makes the tabbox more consistent.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">commit ff531c8e2adc407da00bef88f18d03e3829b25fa
Author: Thomas Lübking
Date: Wed Feb 18 01:37:45 2015 +0100</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">implement showingDesktop by raising the desktop window
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">commit 190a0cc022d9935d658a6218d0b3caa79b038563
Author: Thomas Lübking
Date: Wed Feb 18 00:09:46 2015 +0100</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">remove secret showDesktopIsMinimizeAll feature
</pre></div>
</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">The script (though mostly in KWin4, trouble w/ ksycoca5...)</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Obviously the supersecret key is now dead ;-)</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Been playing around with alternate desktop showing.</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>client.h <span style="color: grey">(f064041)</span></li>
<li>client.cpp <span style="color: grey">(3e834f2)</span></li>
<li>effects/desktopgrid/desktopgrid.cpp <span style="color: grey">(97cb2a3)</span></li>
<li>effects/presentwindows/presentwindows.cpp <span style="color: grey">(07660c2)</span></li>
<li>kwin.kcfg <span style="color: grey">(80ca365)</span></li>
<li>tabbox/tabbox.cpp <span style="color: grey">(f81a407)</span></li>
<li>scripts/minimizeall/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>scripts/minimizeall/contents/code/main.js <span style="color: grey">(PRE-CREATION)</span></li>
<li>scripts/CMakeLists.txt <span style="color: grey">(34dedb7)</span></li>
<li>options.cpp <span style="color: grey">(cdaa851)</span></li>
<li>options.h <span style="color: grey">(67e5868)</span></li>
<li>layers.cpp <span style="color: grey">(91edc04)</span></li>
<li>manage.cpp <span style="color: grey">(f302892)</span></li>
<li>workspace.h <span style="color: grey">(4ecac3d)</span></li>
<li>workspace.cpp <span style="color: grey">(7cbe81e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122679/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>