<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123088/">https://git.reviewboard.kde.org/r/123088/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, Eike Hein and Marco Martin.</div>
<div>By Ivan Čukić.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The experimental library can not land in the kactivities framework just yet. Since it is to be used by plasma-desktop in the next release, we need to include it (for the time being) in p-d.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The idea came from Eike. While it has downsides, it also has a few benefits:
- no need to have a monthly release cycle, so we can actually do work without much bureaucracy surrounding API and ABI compatibility;
- when the library becomes stable, it will move to KActivities and lose the 'experimental' part of the name. This means that the distributions will not have issues of two packages providing the same files;
- no need to sync the releases and think about which KActivities version plasma 5.x will be used against;
- I guess I'm forgetting more benefits. :)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The patch includes update.sh script that syncs this code with that in KActivities. (the development should still be in the KActivities ivan/libkactivities-experimental-stats branch)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(2d43890)</span></li>
<li>lib/kactivities-stats/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/KF5ActivitiesExperimentalStatsConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/README <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/common/database/Database.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/common/database/Database.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/common/database/schema/ResourcesDatabaseSchema.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/common/database/schema/ResourcesDatabaseSchema.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/common/dbus/common.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Activities.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Activities.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Activities.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Features.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.Resources.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.ResourcesLinking.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/common/dbus/org.kde.ActivityManager.ResourcesScoring.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/common/specialvalues.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/lib/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/lib/stats/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/lib/stats/activitiessync_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/lib/stats/activitiessync_p.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/lib/stats/libKActivitiesExperimentalStats.pc.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/lib/stats/query.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/lib/stats/query.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/lib/stats/resultmodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/lib/stats/resultmodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/lib/stats/resultset.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/lib/stats/resultset.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/lib/stats/resultwatcher.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/lib/stats/resultwatcher.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/lib/stats/terms.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/lib/stats/terms.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/lib/stats/version.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/lib/stats/version.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/utils/continue_with.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/utils/d_ptr.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/utils/d_ptr_implementation.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/utils/dbusfuture_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/utils/dbusfuture_p.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/utils/debug_and_return.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/utils/for_each_assoc.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/utils/lazy_val.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/utils/member_matcher.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/utils/merge_into.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/utils/qsqlquery_iterator.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/utils/qsqlquery_iterator.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/utils/range.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/utils/remove_if.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/src/utils/slide.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/kactivities-stats/update.sh <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123088/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>