<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122667/">https://git.reviewboard.kde.org/r/122667/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 3rd, 2015, 5:46 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/122667/diff/3/?file=352798#file352798line80" style="color: black; font-weight: bold; text-decoration: underline;">src/kpackagelauncherqml/main.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">80</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">aboutData</span><span class="p">.</span><span class="n">addAuthor</span><span class="p">(</span><span class="n">author</span><span class="p">.</span><span class="n">name</span><span class="p">(),</span> <span class="n">author</span><span class="p">.</span><span class="n">task</span><span class="p">(),</span> <span class="n">author</span><span class="p">.</span><span class="n">emailAddress</span><span class="p">(),</span> <span class="n">author</span><span class="p">.</span><span class="n">webAddress</span><span class="p">(),</span> <span class="n">author</span><span class="p">.</span><span class="n">ocsUsername</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">we load this, we set the authors then don't do anything with it?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is it used implicitly?</p></pre>
</blockquote>
<p>On March 3rd, 2015, 6:10 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">yeah, i could disable it for now..
I was thinking about exporting it to the qml context somehow, but then didn't decide yet how to use it.
(doing a standard kde about dialog would link to kxmlgui that meh, just having data available to the context I'm not sure how much then applications would use it)</p></pre>
</blockquote>
<p>On March 3rd, 2015, 7:17 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There's a KAboutData::setApplicationData </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">that sets up all the methods on QApplication, sounds perfect I think.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">yeah, good point (done).
would still need a c++ import to access any of that, but at least is possible to access.</p></pre>
<br />
<p>- Marco</p>
<br />
<p>On March 3rd, 2015, 7:29 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated March 3, 2015, 7:29 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeclarative
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is still a bit rough but adding it there for early feedback. comes from the fact that I would like a standard-ish way for KDE apps to do QML based apps</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It adds 3 things:
<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> KPackage support to QmlObject: the class is done to easily load QML without using qquickview, since I want to push loading qml from KPackages, adding kpackage support to this class seems to make sense
</em> qmlpackagelauncher: tiny tool to launch qml apps from qml packages: supports both the case the root object is a qquickitem or an ApplicationWindow qtquickcomponent(that is a window in itself) puts proper window title and icon, sets the kaboutdata from the metadata file, binds commandline arguments in the context (kinda feel some other bindings/API could be needed)
* KPackageView: is a qquickview that loads kpackages... seeing that the direction from Qt of using ApplicationWindow as root item makes me a bit unsure wether to add this tough</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kdeclarative/qmlobject.h <span style="color: grey">(a0a74d3)</span></li>
<li>src/kdeclarative/qmlobject.cpp <span style="color: grey">(00478b4)</span></li>
<li>src/kpackagelauncherqml/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kpackagelauncherqml/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/quickaddons/CMakeLists.txt <span style="color: grey">(8272f1f)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(a8abfaf)</span></li>
<li>tests/helloworld/contents/ui/main.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/helloworld/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/helloworldnowindow/contents/ui/main.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/helloworldnowindow/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(52a698a)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(32da8a5)</span></li>
<li>src/kdeclarative/CMakeLists.txt <span style="color: grey">(052b9e2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122667/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>