<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122668/">https://git.reviewboard.kde.org/r/122668/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 3rd, 2015, 2:36 a.m. UTC, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/122668/diff/1/?file=351706#file351706line26" style="color: black; font-weight: bold; text-decoration: underline;">CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">26</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">Config</span> <span class="s">ConfigWidgets</span> <span class="s">CoreAddons</span> <span class="s">I18n</span> <span class="s">KIO</span> <span class="s">KCMUtils</span> <span class="s">Plasma</span> <span class="s">Runner</span> <span class="s">Service</span> <span class="s">UnitConversion</span> <span class="s">KDELibs4Support</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">26</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">Config</span> <span class="s">ConfigWidgets</span> <span class="s">CoreAddons</span> <span class="s">I18n</span> <span class="s">KIO</span> <span class="s">KCMUtils</span> <span class="s">Plasma</span> <span class="s">Runner</span> <span class="s">Service</span> <span class="s">UnitConversion</span> <span class="s">KDELibs4Support</span><span class="hl"> </span><span class="s"><span class="hl">NewStuff</span></span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can we remove KDELibs4Support? It doesn't seem to be used in the linker.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">seems to still be used (by showdesktop accessing kglobalsettings atm, i'll try to clean it out)</p></pre>
<br />
<p>- Marco</p>
<br />
<p>On February 25th, 2015, 5 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Feb. 25, 2015, 5 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this ports the comic applet to plasma5 (and the dataengine to kpackage, dropping the support of c++ comic plugins that don't exist anymore since KDE 4.3 anyways)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dataengines/comic/comicproviderkross.h <span style="color: grey">(d80a686)</span></li>
<li>dataengines/comic/comicprovider.h <span style="color: grey">(db3c3f1)</span></li>
<li>dataengines/comic/comic.h <span style="color: grey">(38a3cc2)</span></li>
<li>dataengines/CMakeLists.txt <span style="color: grey">(41288df)</span></li>
<li>applets/comic/plasma-comic-default.desktop <span style="color: grey">(69874bf)</span></li>
<li>applets/comic/package/contents/ui/main.qml <span style="color: grey">(1862475)</span></li>
<li>applets/comic/package/contents/ui/configGeneral.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/comic/package/contents/ui/configAppearance.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/comic/package/contents/ui/configAdvanced.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/comic/package/contents/ui/ImageWidget.qml <span style="color: grey">(e450db6)</span></li>
<li>applets/comic/package/contents/ui/FullViewWidget.qml <span style="color: grey">(f76bd4c)</span></li>
<li>applets/comic/package/contents/ui/ComicCentralView.qml <span style="color: grey">(4204ddc)</span></li>
<li>applets/comic/appearanceSettings.ui <span style="color: grey">(5dc1144)</span></li>
<li>applets/comic/comicdata.h <span style="color: grey">(696dc8a)</span></li>
<li>applets/comic/comicinfo.cpp <span style="color: grey">(c7372ae)</span></li>
<li>applets/comic/comicmodel.h <span style="color: grey">(87b5a0f)</span></li>
<li>applets/comic/comicmodel.cpp <span style="color: grey">(349019d)</span></li>
<li>applets/comic/comicsaver.cpp <span style="color: grey">(cf92c76)</span></li>
<li>applets/comic/comicupdater.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/comic/comicupdater.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/comic/configwidget.h <span style="color: grey">(0bf450f)</span></li>
<li>applets/comic/configwidget.cpp <span style="color: grey">(0d7b149)</span></li>
<li>applets/comic/package/contents/config/config.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/comic/package/contents/ui/ButtonBar.qml <span style="color: grey">(d10b915)</span></li>
<li>applets/comic/comicarchivedialog.cpp <span style="color: grey">(35902d8)</span></li>
<li>applets/comic/comicarchivejob.h <span style="color: grey">(2ee1428)</span></li>
<li>dataengines/comic/comicprovider.cpp <span style="color: grey">(2e5bb16)</span></li>
<li>dataengines/comic/comic_package.cpp <span style="color: grey">(c4d466f)</span></li>
<li>dataengines/comic/comicproviderkross.cpp <span style="color: grey">(c2c9ee9)</span></li>
<li>dataengines/comic/comicproviderwrapper.h <span style="color: grey">(499f338)</span></li>
<li>dataengines/comic/comicproviderwrapper.cpp <span style="color: grey">(f60a4f6)</span></li>
<li>dataengines/comic/plasma-packagestructure-comic.desktop <span style="color: grey">(e05786a)</span></li>
<li>applets/comic/package/contents/ui/ComicBottomInfo.qml <span style="color: grey">(f5885b1)</span></li>
<li>applets/comic/comicdata.cpp <span style="color: grey">(f61be2f)</span></li>
<li>applets/comic/comicarchivejob.cpp <span style="color: grey">(68b42d2)</span></li>
<li>applets/comic/comicarchivedialog.h <span style="color: grey">(2bd6551)</span></li>
<li>applets/comic/comic.knsrc <span style="color: grey">(e9ddbf7)</span></li>
<li>applets/comic/checknewstrips.cpp <span style="color: grey">(8558c9e)</span></li>
<li>applets/comic/advancedsettings.ui <span style="color: grey">(9fc4d21)</span></li>
<li>applets/comic/CMakeLists.txt <span style="color: grey">(9b41b99)</span></li>
<li>CMakeLists.txt <span style="color: grey">(45d05c7)</span></li>
<li>applets/CMakeLists.txt <span style="color: grey">(c65250a)</span></li>
<li>dataengines/comic/comic.cpp <span style="color: grey">(5eab3fc)</span></li>
<li>dataengines/comic/comic_package.h <span style="color: grey">(06b4b52)</span></li>
<li>dataengines/comic/CMakeLists.txt <span style="color: grey">(28ef44f)</span></li>
<li>applets/comic/stripselector.cpp <span style="color: grey">(cd88ea3)</span></li>
<li>applets/comic/package/metadata.desktop <span style="color: grey">(c015137)</span></li>
<li>applets/comic/comicSettings.ui <span style="color: grey">(fd73d47)</span></li>
<li>applets/comic/comic.h <span style="color: grey">(d460b11)</span></li>
<li>applets/comic/comic.cpp <span style="color: grey">(8352eee)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122668/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>