<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122450/">https://git.reviewboard.kde.org/r/122450/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 27th, 2015, 3:51 p.m. CET, <b>Dan Meltzer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm a little late to the party, but this seems like it would cause a regression for anyone not using plasma workspace... right? Isn't it a kded bug that the shortcuts don't get forwarded to the active window?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm a little late to the party, but this seems like it would cause a regression for anyone not using plasma workspace... right?</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">no, for upgrades it shouldn't matter (though haven't tested), a configured shortcut would stay (we will probably do something in plasma about that to more agressively steal the shortcut from amarok). For new setups it can still be configured. So it's just a change in the default. And even then I would say that this fixes a very severe bug in the inter-application play. As kglobalaccel maintainer I think it was a pretty severe application abuse to take the shortcut away from any other media application.</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Isn't it a kded bug that the shortcuts don't get forwarded to the active window?</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">eh no. That would be pretty bad if the shortcut would be passed to the active window. Just imagine the shortcut "Ctrl+F1". Whenever you press that to get to desktop 1 it would also open the help in the active application. Global shortcuts need to be filtered out.</p></pre>
<br />
<p>- Martin</p>
<br />
<p>On February 27th, 2015, 1:50 p.m. CET, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Amarok and Plasma.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Feb. 27, 2015, 1:50 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
amarok
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Amarok used to grab the keys for:
* Qt::Key_MediaPlay
* Qt::Key_MediaStop
* Qt::Key_MediaNext
* Qt::Key_MediaPrevious
As those are global shortcuts they are taken away from any other
application when Amarok is running. E.g. if I watch a movie in VLC
and press the media play button (which VLC handles) Amarok will start
playback if it's running. If Amarok is not running, VLC will pause
the playback. This shows that a multi-media application should not
globally grab these keys.
In addition we just introduced a change [1] in plasma-workspace for the
Plasma/5.3 release to grab these shortcuts and bind them to the
mpris2 dataengine. Now the mpris2 engine handles those shortcuts and
delegates to the currently active application.
[1] http://commits.kde.org/plasma-workspace/409fdfab03e7a0b5a61e7796e1fba85b143eab3b</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ActionClasses.cpp <span style="color: grey">(3f6a63e073f76db8ec05daf531dd2d828d3f9c0d)</span></li>
<li>src/MainWindow.cpp <span style="color: grey">(484f4251f8911f1c4e63f61ae17efd7b17b5c4e6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122450/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>