<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122662/">https://git.reviewboard.kde.org/r/122662/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, Bhushan Shah and Marco Martin.</div>
<div>By Ivan Čukić.</div>
<p style="color: grey;"><i>Updated Feb. 21, 2015, 4:46 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- not installing .h .cpp files
- reusing action names from old plasma-workspace actions (the actions should be removed - I'll do it at the same time this is merged)</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch provides the following:</p>
<ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">A C++ backend object for activity switcher</p>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">provides cached wallpaper thumbnails for faster switcher loading</p>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">registers the keyboard shortcuts for activity switching</p>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Patch to the UI</p>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">To show the switcher when the user switches activities via the keyboard shortcut (it shows the version without advanced controls like search and activity creation / manipulation)</p>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Merged ActivityBrowser.qml and ActivityManager.qml into one</li>
</ol></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There are two issues currently:
- one for showing the wallpapers on meta-tab switcher mode
- the activity switching has an artificial delay because plasma dead-locks if the side panel is loaded while the activity is being switched.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>desktoppackage/contents/activitymanager/ActivityList.qml <span style="color: grey">(8baa801)</span></li>
<li>desktoppackage/contents/activitymanager/ActivityManager.qml <span style="color: grey">(ce2712c)</span></li>
<li>desktoppackage/contents/views/Desktop.qml <span style="color: grey">(319da90)</span></li>
<li>imports/activitymanager/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>imports/activitymanager/activityswitcherextensionplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>imports/activitymanager/activityswitcherextensionplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>imports/activitymanager/qmldir <span style="color: grey">(PRE-CREATION)</span></li>
<li>imports/activitymanager/switcherbackend.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(7c6284c)</span></li>
<li>desktoppackage/contents/activitymanager/ActivityBrowser.qml <span style="color: grey">(1ea5e2b)</span></li>
<li>desktoppackage/contents/activitymanager/ActivityItem.qml <span style="color: grey">(e34402b)</span></li>
<li>imports/activitymanager/switcherbackend.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122662/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>