<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122619/">https://git.reviewboard.kde.org/r/122619/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, Plasma, Alex Richardson, David Faure, and Marco Martin.</div>
<div>By Sebastian Kügler.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcoreaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add support for Hidden key
This key does not make a lot of sense for binary plugins (those loaded
from .so files which retrieve their metadata from the json-embedded
data), but is useful for plugins loaded from .desktop files.
This allows us to override the visibility of installed plugins by the
user.
I'm only considering the Hidden key here. I am not sure how the
NoDisplay key (which seems to be used here and there), so maybe we
should also consider NoDisplay. This is the most basic patch we can
achieve the desired results with, however.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Added autotest to make sure both cases work</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Tried to hide a KPackage by adding a Hidden=true to the metadata.desktop file</li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Both work as expected with this patch.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/data/hiddenplugin.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/kpluginmetadatatest.cpp <span style="color: grey">(8a14f57dd0a8650f41185290da966f036cb66fb6)</span></li>
<li>src/lib/plugin/desktopfileparser.cpp <span style="color: grey">(b1b5440b48e4fd412932a7d7e794d641b1406699)</span></li>
<li>src/lib/plugin/kpluginmetadata.h <span style="color: grey">(7ca6747c766d92be828fa3350d088a2f8b1b12f4)</span></li>
<li>src/lib/plugin/kpluginmetadata.cpp <span style="color: grey">(cf90ebc204186f26a3199753fb8c97922a278bd1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122619/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>